Tests are failing.

@laoneo the msg is: Undefined property: JLayoutFile::$value but I can't run phpunit locally without an error Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes) in /Users/dimitris/Documents/github_projects/joomla1/libraries/joomla/log/entry.php on line 103

Any hints are welcome

Will have a look.

The value attribute is not set and the order of the attributes is not correct with what is expected in the test data.

Glad it is passing now and that github allows to squash pull requests ?

That looks better ?
@laoneo you realise that I used your code (from your PR for pagination) for eliminating the spaces in the UT?

Yes saw it. Perhaps we need to find a way to improve that situation. Otherwise we have to copy that all the time. Any suggestions?

maybe use a dom parser?

something like https://github.com/paquettg/php-html-parser

I can't run phpunit locally without an error Fatal error: Allowed memory size of 134217728 bytes exhausted

IIRC PHP has to have something around 320M memory to run the CMS' test suite in full without the code coverage reports.

@dgt41 good idea, will have a look tomorrow if I can come up with a proper solution.

Idiot me, PHPUnit comes with XML string asserts. Have a look on 7731ef8. There is no need anymore for the ugly str_replace code ?

I will apply this to all the modified tests (damn, there are a lot of them...)

Maybe strip the tests from the layout PRs and do all the uit tests as one
Pr ?

On 6 July 2016 at 09:43, Dimitri Grammatikogianni notifications@github.com
wrote:

I will apply this to all the modified tests (damn, there are a lot of
them...)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10994 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8Ss6taMN8OtMiR7DGaWF2B1bixVvks5qS2q-gaJpZM4JDtue
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

When we move the hardcoded HTML output to layout's, the tests start failing, that's why the need to be updated within the PR.

I applied patch and tested input field with type 'tel'. Nothing new, works same as normal text field. How to check tel validations? Rules?