PR-staging

Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Jun 2016

Summary of Changes

JArrayHelper => ArrayHelper

Testing Instructions

Please make sure that the backend components still works as before.
Code Review ;)

avatar zero-24 zero-24 - open - 24 Jun 2016
avatar zero-24 zero-24 - change - 24 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2016
Labels Added: PR-staging
avatar brianteeman brianteeman - change - 24 Jun 2016
Category Administration Code style Components
avatar crommie crommie - test_item - 25 Jun 2016 - Tested successfully
avatar crommie
crommie - comment - 25 Jun 2016

I have tested this item successfully on 1dfcb76

Everything looks ok.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10923.

avatar roland-d roland-d - test_item - 25 Jun 2016 - Tested successfully
avatar roland-d
roland-d - comment - 25 Jun 2016

I have tested this item successfully on 1dfcb76

After applying the patch, there are no obvious issues, everything works as before. Code review looks good as well.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10923.

avatar roland-d roland-d - change - 25 Jun 2016
Status Pending Ready to Commit
avatar roland-d roland-d - change - 25 Jun 2016
Milestone Added:
avatar zero-24
zero-24 - comment - 26 Jun 2016

Thanks! @joomla-cms-bot


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10923.

avatar zero-24
zero-24 - comment - 13 Jul 2016

@brianteeman can we fix / remove the milestone please?

avatar rdeutz rdeutz - change - 13 Jul 2016
Milestone Added:
avatar rdeutz rdeutz - change - 13 Jul 2016
Milestone Removed:
avatar rdeutz
rdeutz - comment - 13 Jul 2016

I am not Brian but I think you asked for a 3.6.1 Milestone

avatar zero-24
zero-24 - comment - 13 Jul 2016

Thanks 😄

avatar zero-24
zero-24 - comment - 21 Jul 2016

Is there any reason to not merge this one?

avatar roland-d
roland-d - comment - 23 Jul 2016

@zero-24 I am not merging because I am one of the testers. Nudge @wilsonge :)

avatar wilsonge
wilsonge - comment - 23 Jul 2016

As per the same refactor in #10676 It's not a bug fix so it's not really a patch release. So I think this is a 3.7 thing - but will merge it soon enough :)

avatar wilsonge
wilsonge - comment - 30 Jul 2016

Merged with 9ef83f7 - Thanks Tobias :)

avatar wilsonge wilsonge - change - 30 Jul 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-07-30 14:30:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Jul 2016
avatar wilsonge wilsonge - close - 30 Jul 2016
avatar wilsonge wilsonge - change - 30 Jul 2016
Labels Removed: RTC

Add a Comment

Login with GitHub to post a comment