[#10922] - JArrayHelper => ArrayHelper for the frontend components
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10922
- Diff
- zero-24:arrayhelper_components
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
JArrayHelper => ArrayHelper
Testing Instructions
Please make sure that com_banners, com_config, com_content, com_tags & com_users (remind) still works as before.
Code Review ;)
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style Components |
@grhcj Yes, It is! See #8396 and #8396 (comment)
Line 430 (old) was ineffective because JArrayHelper::toString($authorAlias); didn't change the $authorAlias. That may be a leftover from old revisions.
Line 431 (new) Converts to the array to string that is further used for foreach iteration.
We (including me) should make a habit to look for any pending PR before duplicating efforts, as much as possible.
@izharaazmi OK, you're right, so I will wait for @zero-24's correction for this and then review again.
This PR has received new commits.
CC: @grhcj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10922.
I have tested this item
On Review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10922.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10922.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 15:03:55 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 41cac17
Comment by @izharaazmi isn't part of this pr imho.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10922.