Joomla! Issue Tracker | Joomla! CMS #10889 - Media form field bootstrapped with static preview

Fixed in Code Base
1 Oct 2016
Medium
Build: 3.7.x
# 10889
Diff
dgt41:imagePreview

Success

Success continuous-integration/drone the build was successful Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details

Pull Request for # 10800

User tests: Successful: Unsuccessful:

dgt41
21 Jun 2016

Pull Request for Issue #10800

Summary of Changes

Restore the static preview as an alternative to the pop over

Just a note here:

THIS AFFECTS CODE THAT IS NOT YET ACCEPTED IN CORE JOOMLA

Testing Instructions

Apply this PR
edit administrator/components/com_content/models/forms/article.xml and replace the intro image field with:

        <field
            name="image_intro"
            type="media"
            label="COM_CONTENT_FIELD_INTRO_LABEL"
            description="COM_CONTENT_FIELD_INTRO_DESC"
            preview="true"
            preview_width="300"
            preview_height="300"
        />

edit an article and observe the changes!

PS for maintainers this also includes the #10788 which is already RTC

dgt41 - open - 21 Jun 2016

dgt41 - change - 21 Jun 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 21 Jun 2016

Labels

Added: ?

brianteeman - change - 21 Jun 2016

Category

⇒

Fields

brianteeman - change - 21 Jun 2016

Rel_Number	0	⇒	10800
Relation Type		⇒	Pull Request for

brianteeman - test_item - 21 Jun 2016 - Tested unsuccessfully

brianteeman - comment - 21 Jun 2016

I have tested this item ? unsuccessfully on c9f4246

Assuming I tested this correctly this fails

With current staging I modified the intro_image field as described
Selected an image and observed it was displayed in a fixed preview
Applied patch
Observed the image was still displayed in a fixed preview but formatted differently
Selected a different image and that image was previewed AND the previous image.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10889.}

joomla-cms-bot - comment - 21 Jun 2016

This PR has received new commits.

CC: @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10889.}

dgt41 - comment - 21 Jun 2016

Still missing some proper formatting (css)

dgt41 - comment - 21 Jun 2016

By the way the old styling is also way off:

with this PR and no styling whatsoever i thing we are way better:

joomla-cms-bot - comment - 21 Jun 2016

This PR has received new commits.

CC: @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10889.}

brianteeman - test_item - 22 Jun 2016 - Tested unsuccessfully

brianteeman - comment - 22 Jun 2016

I have tested this item ? unsuccessfully on 02a728b

After applying the path the following tabs are all displayed on the same tab
Images and links
Associations
Options
Configure Edit Screen
Permissions

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10889.}

piotr-cz - comment - 22 Jun 2016

What do you think about showing the preview under field controls?
Usually we have label on the left side and controls on the right.

In the preview you've added when I'd like to change the image, controls are not on the same line and I have to look where the image is ending, eventually scroll down and then click.

dgt41 - comment - 22 Jun 2016

@piotr-cz makes sense, will do that

joomla-cms-bot - comment - 25 Jun 2016

This PR has received new commits.

CC: @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10889.}

joomla-cms-bot - comment - 25 Jun 2016

This PR has received new commits.

CC: @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10889.}

dgt41 - comment - 25 Jun 2016