[#10805] - Use JForm and formfields for batch modals
- Closed
- 12 Aug 2016
- Medium
- Build: master
- # 10805
First a comment to #10237
@JoomliC
Is it possible to avoid conflict between the new class "modalTooltip" and the formfields "hasTooltip". I have that problem.
Is it a B/C issue to use JForm and formfields for the batch modals? i.e. the same handling as for the filter form. The following image shows a test with the articles. The fields used are standard and nothing new. The texts are the same - no new textstrings. As far as I understand there have allready bin changes that left some "orphans" in the tmpl folder.
I used a xml description:
batch_articles.xml,
A new method;
getBatchForm($data = array(), $loadData = false),
The same code in default.php:
JHtml::_('bootstrap.renderModal' ...
Except that I replaced the footer and the body with direct calls to new JLayouts,
JLayoutHelper::render('joomla.batchtools.footer',...
JLayoutHelper::render('joomla.batchtools.body',...
Advantage - I can use the formfields and do not need the JHtml::_('batch.language') things.
At least it helped me to run other batch methods on item lists. I have the fields needed anyway.
What do you think?
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | ⇒ | Fields |
@schnuti All i can answer for now is that i didn't have yet redo the batch fields. ;-)
And the modalTooltip class is not new, and not added by me, but added 2 years ago by this PR #3149 (to use a dedicated class to fix Bootstrap tooltip when inside a modal)
The reason you have classes tooltip conflict is because you try to generate the batch content in a different way (in core, no classes conflict) and it is due to the "forced" hasTooltip class in label render jlayout, which is not used to generate core batch form field labels (in the improvement i've planned for batch modals, this won't be the case if you want to propose to use jform xml for batch.).
About using a xml files to generate the batch form fields, well maybe it's possible, as batch fields are generated from a view layout, but not sure it could add a benefit somewhere as if you want to change articles batch modal, you can use an override of the view... (but maybe i miss your intention ?)
Is this still an issue. I think the batch modals have been updated
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10805.
| Status | New | ⇒ | Information Required |
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-12 12:43:40 |
| Closed_By | ⇒ | brianteeman |
I am closing this as stated above. It can always be reopened if updated
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10805.
@JoomliC
More to explain the conflict. I add the new class in the form with labelclass="modalTooltip". The "hasTooltip" is added by the formfield code. i.e. I have 2 classes for the label.
For this test I changed the core code to add "hasTooltip" only if it's emty. That is not B/C!
The Javascript to hide and show copy/move radios do not work in my test.