Feeling Lucky
?
?
[#10804] - Missing and incorrect language keys
- Closed
- 15 Aug 2016
- Medium
- Build: staging
- # 10804
- Diff
- brianteeman:keys
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
- BANNERS_SEARCH_IN_TITLE at: JROOT\administrator\templates\hathor\html\com_banners\banners\default.php:36
- BANNERS_SELECT_TYPE at: JROOT\administrator\templates\hathor\html\com_banners\tracks\default.php:60
- COM_CONTACT_SESSION_INVALID at: JROOT\components\com_contact\controllers\contact.php:64
- COM_FINDER_INDEX_PURGE_FAILED at: JROOT\administrator\components\com_finder\controllers\index.php:58
- COM_LANGS_SEARCH_IN_TITLE at: JROOT\administrator\templates\hathor\html\com_languages\languages\default.php:39
- COM_TAGSS_REBUILD_FAILURE at: JROOT\administrator\components\com_tags\controllers\tags.php:62
- COM_TAGS_DEFAULT_PAGE_TITLE at: JROOT\components\com_tags\views\tags\view.html.php:166
- COM_USERS_FILTER_FILTER_DATE at: JROOT\administrator\templates\hathor\html\com_users\users\default.php:77
- COM_USERS_REMIND_REQUEST_ERROR at: JROOT\components\com_users\controllers\user.php:392
- COM_USER_LOGOUT_IMAGE_ALT at: JROOT\components\com_users\views\login\tmpl\default_logout.php:30
- ERRORUNKOWNEXTENSION at: JROOT\libraries\cms\installer\adapter\library.php:367
- FILTERS at: JROOT\administrator\templates\hathor\html\com_templates\templates\default.php:33
- JERROR_SAVE_NOT_PERMITTED at: JROOT\administrator\components\com_templates\controllers\template.php:221
- JFRAMEWORK_FORM_FIELDS_PLUGINS_ERROR_FOLDER_EMPTY at: JROOT\libraries\joomla\form\fields\plugins.php:144
- JGLOBAL_BATCH_MOVE_ROW_NOT_FOUND at: JROOT\administrator\components\com_categories\models\category.php:1107
- JGLOBAL_BATCH_MOVE_ROW_NOT_FOUND at: JROOT\administrator\components\com_categories\models\category.php:923
- JGLOBAL_BATCH_MOVE_ROW_NOT_FOUND at: JROOT\administrator\components\com_menus\models\item.php:243
- JGLOBAL_BATCH_MOVE_ROW_NOT_FOUND at: JROOT\administrator\components\com_menus\models\item.php:422
- JGLOBAL_UNCATEGORISED at: JROOT\templates\beez3\html\com_content\featured\default_item.php:72
- JGLOBAL_UNCATEGORISED at: JROOT\templates\beez3\html\com_content\featured\default_item.php:84
- JLIB_APPLICATION_ERROR_MENU_LOAD at: JROOT\libraries\cms\menu\menu.php:130
- JLIB_CLIENT_ERROR_JFTP_BAD_RESPONSE_SIZE at: JROOT\libraries\joomla\client\ftp.php:1351
- JLIB_CLIENT_ERROR_JFTP_SYS_BAD_RESPONSE_NATIVE at: JROOT\libraries\joomla\client\ftp.php:447
- JLIB_DATABASE_ERROR_DATABASE_QUERY at: JROOT\installation\model\database.php:339
- JLIB_DATABASE_ERROR_DATABASE_QUERY at: JROOT\installation\model\database.php:356
- JLIB_FILESYSTEM_PATCHER_ADD_LINE at: JROOT\libraries\joomla\filesystem\patcher.php:423
- JLIB_FILESYSTEM_PATCHER_REMOVE_LINE at: JROOT\libraries\joomla\filesystem\patcher.php:413
- JLIB_INSTALLER_ERROR_LIB_REFRESH_MANIFEST_CACHE at: JROOT\libraries\cms\installer\adapter\library.php:501
- JLIB_INSTALLER_ERROR_PACK_REFRESH_MANIFEST_CACHE at: JROOT\libraries\cms\installer\adapter\file.php:634
- JLIB_INSTALLER_ERROR_PACK_REFRESH_MANIFEST_CACHE at: JROOT\libraries\cms\installer\adapter\package.php:686
- JLIB_INSTALLER_ERROR_TPL_REFRESH_MANIFEST_CACHE at: JROOT\libraries\cms\installer\adapter\template.php:606
- JLIB_INSTALLER_INCORRECT_SEQUENCE at: JROOT\libraries\cms\installer\script.php:142
- JLIB_LOGIN_AUTHORISATION at: JROOT\libraries\cms\application\cms.php:850
- JLIB_LOGIN_AUTHORISATION at: JROOT\libraries\legacy\application\application.php:660
- JLIB_LOGIN_DENIED at: JROOT\libraries\cms\application\cms.php:845
- JLIB_LOGIN_DENIED at: JROOT\libraries\legacy\application\application.php:656
- JLIB_LOGIN_EXPIRED at: JROOT\libraries\cms\application\cms.php:840
- JLIB_LOGIN_EXPIRED at: JROOT\libraries\legacy\application\application.php:652
- JLIB_MAIL_MSG at: JROOT\libraries\joomla\mail\mail.php:757
- JLIB_MAIL_MSG_ADMIN at: JROOT\libraries\joomla\mail\mail.php:756
- JLIB_MAIL_USER_SUBMITTED at: JROOT\libraries\joomla\mail\mail.php:754
- JLIB_STEMMER_INVALID_STEMMER at: JROOT\libraries\joomla\language\stemmer.php:58
- JRULE_ALLOWED_INHERITED at: JROOT\libraries\cms\html\rules.php:227
- JRULE_DENIED_INHERITED at: JROOT\libraries\cms\html\rules.php:228
- LIB_CMS_WARNING_PROVIDE_VALID_NAME at: JROOT\libraries\cms\table\corecontent.php:97
- RENAME FAILED at: JROOT\libraries\joomla\filesystem\folder.php:447
- RENAME FAILED at: JROOT\libraries\joomla\filesystem\folder.php:456
- SOME_ERROR_CODE at: JROOT\administrator\components\com_config\model\application.php:177
- SOME_ERROR_CODE at: JROOT\administrator\components\com_config\model\application.php:209
- SOME_ERROR_CODE at: JROOT\administrator\components\com_config\model\application.php:402
- UNKNOWN at: JROOT\libraries\cms\installer\installer.php:2183
- UNKNOWN at: JROOT\libraries\cms\installer\installer.php:2184
removed the fof strings
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Language & Strings |
| Labels | |||
| Labels | |||
infograf768
- comment
- 13 Jun 2016
from ipad
RENAME is wrong. we are no more in the streams conditional afaik
zero-24
- comment
- 13 Jun 2016
- STATUS at: JROOT\libraries\fof\utils\installscript\installscript.php:553
- EXTENSION at: JROOT\libraries\fof\utils\installscript\installscript.php:552
Both are issues with the unsupported upstream repo.
zero-24
- comment
- 13 Jun 2016
We also exclude external libs from CS rules
brianteeman
- comment
- 13 Jun 2016
And mine
infograf768
- comment
- 14 Jun 2016
JLIB_DATABASE_ERROR_DATABASE_QUERY only concerns installation (which is frozen)
Should be something like
INSTL_DATABASE_ERROR_POSTGRESQL_QUERY="PostgreSQL database query failed."
to add after line 193
infograf768
- comment
- 14 Jun 2016
Proposal for
JLIB_INSTALLER_INCORRECT_SEQUENCE
JLIB_INSTALLER_INCORRECT_SEQUENCE="Downgrading from version %1$s to version %2$s is not allowed."
brianteeman
- comment
- 14 Jun 2016
Can I change that to "not possible"
infograf768
- comment
- 14 Jun 2016
Can I change that to "not possible"
Not sure as it seems that it depends on $allowDowngrades which could be used by a 3rd party preflight.
Because of
if (strtolower($type) == 'update' && !$this->allowDowngrades)
brianteeman
- comment
- 14 Jun 2016
I will leave the two strings that are part of the installer to a separate PR as installation is frozen
brianteeman
- comment
- 14 Jun 2016
The installation string changes can be found in #10816
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10804.
infograf768
- comment
- 16 Jun 2016
@brianteeman
Can you solve the conflicts here? Otherwise I am afraid this will have to be postponed to 3.6.1
brianteeman
- comment
- 16 Jun 2016
I will look at the conflicts this morning
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10804.
brianteeman
- comment
- 16 Jun 2016
Done as much as I can
infograf768
- comment
- 17 Jun 2016
let's wait for the acl pr being merged as it looks like the jrule strings are useless. maybe as well for the code using them. in any case they should not be named that way.
brianteeman
- comment
- 15 Aug 2016
resolved conflicts
brianteeman
- comment
- 15 Aug 2016
I am going to close this and redo it
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-15 10:15:18 |
| Closed_By | ⇒ | brianteeman |
JRULE_ALLOWED_INHERITED
JRULE_DENIED_INHERITED
I think this should be
JLIB_RULES_ALLOWED_INHERITED="Allowed (Inherited)"
JLIB_RULES_DENIED_INHERITED="Denied (Inherited)"