[#10794] - Javascript consistency for XTD buttons
- Closed
- 19 Jun 2016
- Medium
- Build: staging
- # 10794
- Diff
- dgt41:JSOverridable
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Use the same pattern for all XTD buttons javascript
Two reasons to have the script in the callable iframe:
- can be overridden easily, with an html override
- no call to
parent.window.Function() - consistency
Summary of Changes
Move code around
Testing Instructions
Create a new article
use the XTD buttons Article and Pagebreak and confirm that everything works as expected
Redo the same with Hathor as your template
Also try to create a menu for a single article, everything should work as usual
Easy testing
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript Plugins |
This PR has received new commits.
CC: @Ruchiranga
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10794.
This PR has received new commits.
CC: @Ruchiranga
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10794.
@Ruchiranga It seems that there was some changes in language column that was never transferred to hathor (?). Fixed now, thanks for finding this!
I have tested this item
When testing on the front end with the Article button
Before patch the arrow becomes a hand when hovering over an article in the list
After the patch the arrow becomes an ibeam when hovering over an article in the list
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10794.
This PR has received new commits.
CC: @brianteeman, @Ruchiranga
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10794.
This PR has received new commits.
CC: @brianteeman, @Ruchiranga
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10794.
This is against DRY. I will come up with something more elegant for this case, sorry for waisting your time here
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-19 13:30:18 |
| Closed_By | ⇒ | dgt41 |
I have tested this item? unsuccessfully on 2d04395
Works fine on Isis template.
When using Hathor template,
Page break works fine.
Gives error "Uncaught SyntaxError: Invalid or unexpected token" on clicking an article from the list of articles.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10794.