[#10792] - Fix wrong quoting in PostgreSQL update files
- Fixed in Code Base
- 15 Jun 2016
- Urgent
- Build: staging
- # 10792
- Diff
- mbabker:pgsql-quoting
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10790
Summary of Changes
Incorrect quoting is used in the PostgreSQL update files resulting in the inability for all ~250 users of this database engine to upgrade to 3.6.
Testing Instructions
Review the modified files in accordance with the PostgreSQL specification.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
|
||
| Priority | Medium | ⇒ | Urgent |
| Category | ⇒ | Installation Postgresql |
Hmm. If I hadn't looked any further I would have said that I tested this succesfully. Because that is what seems to be the case. Until I take a look at Extensions > Manage > Database. See attachments.
screen shot 2016-06-11 at 17 15 18
screen shot 2016-06-11 at 17 15 28
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.
Those are unrelated to this PR. The syntax errors causing the fatal error
from the screenshot in the original issue are fixed.
On Saturday, June 11, 2016, slibbe notifications@github.com wrote:
Hmm. If I hadn't looked any further I would have said that I tested this
succesfully. Because that is what seems to be the case. Until I take a look
at Extensions > Manage > Database. See attachments.
screen shot 2016-06-11 at 17 15 18
https://issues.joomla.org/uploads/1/5f4ab7300a9fe10e6d6b1abb90820179.jpg
screen shot 2016-06-11 at 17 15 28https://issues.joomla.org/uploads/1/21c546fb6708063144d6013f5575e3bb.jpg
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10792
https://issues.joomla.org/tracker/joomla-cms/10792.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10792 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAWfoUoB8U-XxcpUfAFcLEBufRVTyqnGks5qKzPRgaJpZM4Izkcf
.
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.
@slibbe Tested the statements you reported with pgAdmin, they are correct. Suggest to verify logs/joomla_update.php to see what went wrong with your update!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.
@sovainfo logs/joomla_update.php doesn't give a clue as to what went wrong.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
wilsonge
- 
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-15 22:15:16 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on c21374d
Works!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.