Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10791] - Bootstrap popup with mootools compatibility #2

? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
11 Jun 2016

This fixes a B/C for form field user

Summary of Changes

Introduce an option that will provide the needed backwards compatibility.

Testing Instructions

Apply patch

  • Bootstrap mode
    Test creating a new article and ensure that the field for selecting a user still works.

  • Mixed mode
    Edit administrator/components/com_content/views/article/tmpl/edit.php
    and paste the code bellow after line 81 (just before ?>)

JHtml::_('behavior.modal');

$idTag = 'jform_name';

$test_control[] = '<input type="text" disabled id="' .$idTag . '_id" name="' . $idTag . '" value="" style="display: block"/>';

$test_control[] = '<a class="modal btn" title="XXXXX" href="index.php?option=com_users&amp;view=users&amp;layout=modal&amp;tmpl=component&amp;required=1&amp;field=jform_name"'
    . ' rel="{handler: \'iframe\', size: {x: 800, y: 500}}">SELECT MOOTOOLS</a>';

echo implode('', $test_control);

Test again the previous scenario as well as the new button that will appear above the tabs (that's a mootools modal). The field should be filled with the user id selected in the pop up

  • Compatibility Mode (AKA Mootools) Keep the changes in edit.php Rename administrator/templates/isis/html/layouts/joomla/form/field/user.php to xxxuser.php Repeat the previous testing steps
avatar dgt41 dgt41 - open - 11 Jun 2016
avatar dgt41 dgt41 - change - 11 Jun 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jun 2016
Labels Added: ?
avatar dgt41 dgt41 - change - 11 Jun 2016
Title
…
Bootstrap popup with motors compatibility #2
Bootstrap popup with mootools compatibility #2
avatar dgt41 dgt41 - change - 11 Jun 2016
Title
…
Bootstrap popup with motors compatibility #2
Bootstrap popup with mootools compatibility #2
avatar dgt41 dgt41 - change - 11 Jun 2016
The description was changed
avatar dgt41
dgt41 - comment - 11 Jun 2016

@Fedik can you review this one as well?

avatar Fedik
Fedik - comment - 12 Jun 2016

@dgt41 to be honest I am not very understand what is going on here ???? but I try some test, maybe this evening

avatar Fedik Fedik - test_item - 12 Jun 2016 - Tested successfully
avatar Fedik
Fedik - comment - 12 Jun 2016

I have tested this item ✅ successfully on 4953c0c

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.

avatar JoomliC
JoomliC - comment - 12 Jun 2016

In compatibility mode (with override removed from Isis, and so in mootools modal) the no-user is broken (but it was a "not" visible issue before excepted when tested B/C after layout removal).
I fix this here : https://github.com/joomla/joomla-cms/pull/10772/files#diff-8369fe928ed3e29986d8f380ed245ef2R52 (missing window.parent.jSelectUser(this) on click for no user button)

Another issue (but was there before, so not due to your PR, but could be fixed in the same time) : in all testing cases, if you select no user, you will have the text "Select a user." as the field user name value, where it should be just a placeholder.
But this needs i think, to add this in fielduser.js to set placeholder, and set name as empty.

About your code, after tests all seems good! ????

avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Jun 2016

This PR has received new commits.

CC: @Fedik

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.

avatar dgt41
dgt41 - comment - 13 Jun 2016

@JoomliC I've fixed the No-User button

avatar JoomliC
JoomliC - comment - 13 Jun 2016

@dgt41 Confirm that no user button is fixed. ?
What about the field name value on "no user" click ? To have a placeholder instead ?

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Jun 2016

This PR has received new commits.

CC: @Fedik

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.

avatar brianteeman brianteeman - change - 24 Jun 2016
Category ⇒ Fields
avatar rahulkoshti rahulkoshti - test_item - 1 Jul 2016 - Tested successfully
avatar rahulkoshti
rahulkoshti - comment - 1 Jul 2016

I have tested this item ✅ successfully on a337e9b

Tested Successfully in Joomla! 3.6.0-rc.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.

avatar gautamtailored gautamtailored - test_item - 1 Jul 2016 - Tested successfully
avatar gautamtailored
gautamtailored - comment - 1 Jul 2016

I have tested this item ✅ successfully on a337e9b

Successfully Tested.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.

avatar gunjanpatel gunjanpatel - change - 1 Jul 2016
Status Pending ⇒ Ready to Commit
avatar gunjanpatel
gunjanpatel - comment - 1 Jul 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2016
Labels Added: ?
avatar roland-d roland-d - close - 16 Jul 2016
avatar roland-d roland-d - merge - 16 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Jul 2016
avatar roland-d roland-d - change - 16 Jul 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-07-16 19:07:18
Closed_By ⇒ roland-d
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment