[#10755] - Clean up ACL checking
- Fixed in Code Base
- 8 Jun 2016
- Medium
- Build: staging
- # 10755
- Diff
- roland-d:fix-acl-superusers
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This change fixes the reporting of the ACL settings.
Testing Instructions
- Go to System -> Global configuration -> Permission
- Click on Super User
- You will see that the permissions will show allowed/not allowed instead of Allowed (Super User)
- Click on Administrator
- You will see that the permissions will show as Allowed (Super User) / Not allowed even if a permission is set to Allowed.
- Apply the patch
- Go to System -> Global configuration -> Permission
- Click on Super User
- You will see that the permissions will now show Allowed (Super User) for all of them
- Click on Administrator
- You will see that the permissions will now show as Allowed / Not allowed / Conflict (depends on your settings)
- Please also check the other ACL settings you have in use to make sure all reported statuses are correct.
Calling @andrepereiradasilva and @infograf768 for special attention :)
| Status | New | ⇒ | Pending |
| Milestone |
Added: |
||
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | ACL |
@infograf768 The AJAX results after saving are not part of this PR, I am going to make a separate one for that.
As for the Denied, if I am not mistaken, this is always overriden by the Super User setting or not?
As for the Denied, if I am not mistaken, this is always overriden by the Super User setting or not?
The calculated settings after saving are correct. I will test now site login (for example) after and before save.
@infograf768 I have not looked at the AJAX results yet, that will be the next PR :)
Perpahs we should show the Conflict status if you set this to Denied but it is overruled.
Perpahs we should show the Conflict status if you set this to Denied but it is overruled.
Well, if the Ajax issue is solved, it should not stay at all in the New settings box, should'nt it?
Or should it until Save? If yes, adding the Conflict status looks like the only solution before Save.
@infograf768 Even with AJAX, we can't change the dropdown back to what it was as it will appear as nothing worked. We can then show the Conflict status and perhaps a message that the change wasn't saved because of it.
Will this be still updated or can I mark the test as succesful? It is quite urgent to get it in.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10755.
@infograf768 This PR is ready to go, I am working on the AJAX code now.
I have tested this item
OK here. One more tester.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10755.
if super user cannot be changed can't we disable the select boxes for the super user group?
Or return a js message saying that cannot be changed?
Update: Froget it i saw your other PR now.
I have tested this item
works as described. thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10755.
@andrepereiradasilva Thanks for the test. I was actually thinking, on the Super User tab, you only need the Super User privilege. The rest is useless basically. Indeed, this would be for another PR.
| Status | Pending | ⇒ | Ready to Commit |
RTC as we have 2 succesful tests
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10755.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-08 15:38:28 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Corrects a lot of stuff. Still some Ajax issues I guess.
Test on staging:
before, for superUser
Before, for administrator
After, for superuser
After for administrator
BUT, if I change a permission to Denied for superUser , before save I get
and after save
So, this is a small problem, but it also shows (and I have seen that all over before or after patch), that we have to save the permissions to get the correct saved settings.
Ajax does not do its job OK.
Alas, a PR took off the instruction to Save the permissions in lang strings:
See #10115