? Pending

User tests: Successful: Unsuccessful:

avatar addondev
addondev
7 Jun 2016

Pull Request for Issue # Broken alternative title in the Content - Pagebreak plugin

Summary of Changes

The attributes are not parsed if their order is different from '#<hr(.*)class="system-pagebreak"(.*)\/>#iU'. As a result, an alternative title does not appear. In order to parse the second capture group, it must be concatenated with the first capture group.

Testing Instructions

I

  1. Create an article.
  2. Enable pagination by adding tags <hr class="system-pagebreak" />.
  3. If you set the alternative title attribute before the class attribute <hr title="title" alt="alt" class="system-pagebreak" />, it will work.
  4. If you set the title attribute after the classname attribute <hr class="system-pagebreak" title="title" alt="alt" />, the alternative title will not be set.

II

  1. Try to create a page break without a self-closing slash (which is valid in HTML5) <hr class="system-pagebreak"> – it will fail.
avatar addondev addondev - open - 7 Jun 2016
avatar addondev addondev - change - 7 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2016
Labels Added: ?
avatar addondev addondev - change - 7 Jun 2016
The description was changed
avatar addondev addondev - change - 7 Jun 2016
The description was changed
avatar brianteeman brianteeman - change - 8 Jun 2016
Category Plugins
avatar brianteeman
brianteeman - comment - 8 Jun 2016

Am I correct that this "bug" can only be observed if you write the tags manually and are not using the editor-xtd plugin


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10754.

avatar addondev
addondev - comment - 8 Jun 2016

Brian, this bug (without quotes) can be observed independently of the way of creating tags. I use Code Mirror, and it insertes the title after the class attribute.

avatar brianteeman
brianteeman - comment - 8 Jun 2016

I ask this because it is important for testers to know how to recreate the
issue

On 8 June 2016 at 09:31, Philip Sorokin notifications@github.com wrote:

Brian, this bug (without quotes) can be observed independently of the way
of creating tags. I use Code Mirror, and it insertes the title after the
class attributes.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10754 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8Xk3Hj0eK61pj4MY9T0Efag_UaaYks5qJn3KgaJpZM4IwcQ0
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar addondev
addondev - comment - 8 Jun 2016

I noticed that making the self-closing slash optional is not working. So, I have edited this PR.

avatar addondev addondev - change - 8 Jun 2016
The description was changed
avatar brianteeman
brianteeman - comment - 8 Jun 2016

I just tested and I cannot replicate the problem
1. Tested with tinymce pagebreak - no problem
2. Tested with codemirror pagebreak - no problem (the code generated is the same as above)
3. Tested pasting pagebreak code manually in the "wrong" order - no problem

Please see the video for tests 2 and 3
https://www.dropbox.com/s/aalqneftgq9222r/10754.mp4?dl=0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10754.

avatar addondev
addondev - comment - 8 Jun 2016

@brianteeman, the alias is correct in any case, while the meta tag <title>Is not changing</title> if the order of attributes is as described above.

avatar brianteeman brianteeman - test_item - 8 Jun 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 8 Jun 2016

I have tested this item successfully on 51e1172

I see what you mean now and the PR fixes that issue - however the only way I can get the code in the wrong order is by entering it manually. The editor plugin always does it correctly


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10754.

avatar addondev
addondev - comment - 8 Jun 2016

As far, as I know, Code Mirror always insertes page breaks like this: <hr class="system-pagebreak" title="title" alt="description" />. This order breaks the title. However, it is correct when I put the title and alias attributes manually before the class attribute.

avatar brianteeman
brianteeman - comment - 8 Jun 2016

Isnt it the other way around

On 8 June 2016 at 19:03, Philip Sorokin notifications@github.com wrote:

As far, as I know, Code Mirror always insertes page breaks like this: class="system-pagebreak" title="title" alt="description" />. This order
breaks the title. However, it is correct when I put the title and alias
attributes manually before the class attribute.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10754 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8RzWvHIZDghsXmZrbGqj3Rw1Igrjks5qJwP6gaJpZM4IwcQ0
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar addondev
addondev - comment - 8 Jun 2016

I have checked again, and it is not.

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Jun 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10754.

avatar addondev
addondev - comment - 18 Jun 2016

Will it be a part of Joomla! 3.6?

avatar crommie crommie - test_item - 25 Jun 2016 - Tested unsuccessfully
avatar crommie
crommie - comment - 25 Jun 2016

I have tested this item ? unsuccessfully on 7d05595

Tested according to instructions, using CodeMirror.
Set alternative title attribute before class attribute (step 3): working as described in instructions.
Set alternative title after classname attribute (step 4): not working as described in instructions: alt title is set.
Try to create page break without a self closing slash (step I-1): fails, and still fails after applying patch.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10754.

avatar brianteeman
brianteeman - comment - 4 Dec 2016

@addondev please can you check the failure report above


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10754.

avatar brianteeman brianteeman - change - 4 Dec 2016
Status Pending Information Required
avatar brianteeman brianteeman - change - 4 Dec 2016
Labels Removed: ?
avatar brianteeman brianteeman - edited - 4 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - change - 4 Dec 2016
Category Plugins Front End Plugins
avatar philip-sorokin
philip-sorokin - comment - 4 Dec 2016

@brianteeman
This PR requires more work. So, it should be closed. I will open a new one.

avatar philip-sorokin philip-sorokin - change - 4 Dec 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-12-04 15:23:40
Closed_By philip-sorokin
Labels Added: ?
avatar philip-sorokin philip-sorokin - close - 4 Dec 2016

Add a Comment

Login with GitHub to post a comment