User tests: Successful: Unsuccessful:
Pull Request for Issue # Broken alternative title in the Content - Pagebreak plugin
The attributes are not parsed if their order is different from '#<hr(.*)class="system-pagebreak"(.*)\/>#iU'
. As a result, an alternative title does not appear. In order to parse the second capture group, it must be concatenated with the first capture group.
<hr class="system-pagebreak" />
.<hr title="title" alt="alt" class="system-pagebreak" />
, it will work.<hr class="system-pagebreak" title="title" alt="alt" />
, the alternative title will not be set.<hr class="system-pagebreak">
– it will fail.Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Plugins |
Brian, this bug (without quotes) can be observed independently of the way of creating tags. I use Code Mirror, and it insertes the title after the class attribute.
I ask this because it is important for testers to know how to recreate the
issue
On 8 June 2016 at 09:31, Philip Sorokin notifications@github.com wrote:
Brian, this bug (without quotes) can be observed independently of the way
of creating tags. I use Code Mirror, and it insertes the title after the
class attributes.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10754 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8Xk3Hj0eK61pj4MY9T0Efag_UaaYks5qJn3KgaJpZM4IwcQ0
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I noticed that making the self-closing slash optional is not working. So, I have edited this PR.
I just tested and I cannot replicate the problem
1. Tested with tinymce pagebreak - no problem
2. Tested with codemirror pagebreak - no problem (the code generated is the same as above)
3. Tested pasting pagebreak code manually in the "wrong" order - no problem
Please see the video for tests 2 and 3
https://www.dropbox.com/s/aalqneftgq9222r/10754.mp4?dl=0
@brianteeman, the alias is correct in any case, while the meta tag <title>Is not changing</title>
if the order of attributes is as described above.
I have tested this item
I see what you mean now and the PR fixes that issue - however the only way I can get the code in the wrong order is by entering it manually. The editor plugin always does it correctly
As far, as I know, Code Mirror always insertes page breaks like this: <hr class="system-pagebreak" title="title" alt="description" />
. This order breaks the title. However, it is correct when I put the title and alias attributes manually before the class attribute.
Isnt it the other way around
On 8 June 2016 at 19:03, Philip Sorokin notifications@github.com wrote:
As far, as I know, Code Mirror always insertes page breaks like this: class="system-pagebreak" title="title" alt="description" />. This order
breaks the title. However, it is correct when I put the title and alias
attributes manually before the class attribute.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10754 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8RzWvHIZDghsXmZrbGqj3Rw1Igrjks5qJwP6gaJpZM4IwcQ0
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have checked again, and it is not.
This PR has received new commits.
CC: @brianteeman
Will it be a part of Joomla! 3.6?
I have tested this item
Tested according to instructions, using CodeMirror.
Set alternative title attribute before class attribute (step 3): working as described in instructions.
Set alternative title after classname attribute (step 4): not working as described in instructions: alt title is set.
Try to create page break without a self closing slash (step I-1): fails, and still fails after applying patch.
@addondev please can you check the failure report above
Status | Pending | ⇒ | Information Required |
Labels |
Removed:
?
|
Category | Plugins | ⇒ | Front End Plugins |
@brianteeman
This PR requires more work. So, it should be closed. I will open a new one.
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-04 15:23:40 |
Closed_By | ⇒ | philip-sorokin | |
Labels |
Added:
?
|
Am I correct that this "bug" can only be observed if you write the tags manually and are not using the editor-xtd plugin
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10754.