[#10731] - Make sure we check on the action name
- Fixed in Code Base
- 5 Jun 2016
- Medium
- Build: staging
- # 10731
- Diff
- roland-d:fix-acl-checks
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10552
Summary of Changes
When checking the access status for a given action, we should check on that current active action. This was hardcoded to core.admin so only this action was checked. This change fixes that.
Testing Instructions
- Go to System -> Global Configuration
- Click on Banners
- Click on the Permission Tab
- Click on the Administrator group and see the following permissions:
5. All Calculated settings are set to Allowed (Super User)
6. This is wrong because Configure Options Only is not set to allowed anywhere
7. Apply the patch and reload the page
8. Click on the Administrator group and see the following permissions:
9. The Configure Options Only is now set to Not Allowed as it should be
Known issues
The setting of (Super User) is not correct either but this pull request doesn't fix that. The plan is to propose multiple small pull requests to fix the ACL issues. This way we can keep track of the changes easier.
| Status | New | ⇒ | Pending |
| Milestone |
Added: |
||
joomla-cms-bot
- | Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10731.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-05 14:36:08 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
@andrepereiradasilva That is to be expected since we are now checking against the correct action, so the Super User needs to be fixed. I will look into this and post another PR for this case.
ok thanks for the feedback
I have tested this item✅ successfully on d7bdbd2
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10731.