? Success

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
5 Jun 2016

Pull Request for Issue #10694

Summary of Changes

File is outdated since com_contact was moved to JForm API in Joomla 1.6.? a34dd3d#diff-bcdc310b6bd770234bbf93e90ba81937
form.xml was replaced by contact.xml

Testing Instructions

Remove file /components/com_contact/models/forms/form.xml from your Joomla installation and check that functionality of com_contact hasn't changed. New, Edit, Display of single contact etc.

avatar bertmert bertmert - open - 5 Jun 2016
avatar bertmert bertmert - change - 5 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jun 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 5 Jun 2016

I am guessing that it was kept originally because a third party template
could be using it and unless it has been marked as deprecated we cant just
remove it all we can do at this time is mark it deprecated.

On 5 June 2016 at 09:54, bertmert notifications@github.com wrote:

Pull Request for Issue #10694
#10694
Summary of Changes

File is outdated since com_contact was moved to JForm API in Joomla 1.6.?
a34dd3d#diff-bcdc310b6bd770234bbf93e90ba81937
a34dd3d#diff-bcdc310b6bd770234bbf93e90ba81937
form.xml was replaced by contact.xml
Testing Instructions

Remove file /components/com_contact/models/forms/form.xml from your Joomla
installation and check that functionality of com_contact hasn't changed.

New, Edit, Display of single contact etc.

You can view, comment on, or merge this pull request online at:

#10730
Commit Summary

  • Delete unused/outdated file form.xml

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10730, or mute the thread
https://github.com/notifications/unsubscribe/ABPH8W6Og0z5wFerp8f5WW9zo9ksBwTiks5qIo7SgaJpZM4IuUAM
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar bertmert bertmert - change - 5 Jun 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-06-05 09:14:32
Closed_By bertmert
avatar bertmert bertmert - close - 5 Jun 2016
avatar bertmert bertmert - close - 5 Jun 2016
avatar chrisdavenport
chrisdavenport - comment - 5 Jun 2016

Technically I think we could remove it because it's not part of our BC promise. However, I agree that we probably shouldn't. Could we at least insert a comment into it to the effect that it will be removed at some point and shouldn't be used if at all possible?

Add a Comment

Login with GitHub to post a comment