The !empty check is functionally the same as the isset && has value check.

On Saturday, June 4, 2016, RolandD notifications@github.com wrote:

Summary of Changes

This pull request does 2 things:
1. Move the loading of JS files to the top, no need to call it within the
foreach loop (logical error)
2. A little codestyle cleanup
Testing Instructions

1. Apply patch
2. Go to System -> Global Configuration and check the tabs and options still show and function as usual

---

You can view, comment on, or merge this pull request online at:

#10723
Commit Summary

• Code cleanup

File Changes

• M layouts/joomla/content/options_default.php https://github.com/joomla/joomla-cms/pull/10723/files#diff-0 (19)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/10723.patch
• https://github.com/joomla/joomla-cms/pull/10723.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10723, or mute the thread
https://github.com/notifications/unsubscribe/AAWfoX4i0CExRYmJphG_wTbxkjWKJNi5ks5qIclFgaJpZM4IuMVc
.

The idea of the JS being loaded in the foreach is to only load it if showon is requested. You're loading it now no matter if it is needed or not. So it's not a logical error, it's a design question.

Ok, thanks for the feedback, seems these changes are not needed.