? Success

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
4 Jun 2016

Summary of Changes

The folderlist form field got a new option to show the list the folders recursive.

Testing Instructions

  • Add the following XML string to the file administrator/components/com_content/models/forms/article.xml in the basic fieldset around line 152.
    <field name="directory" type="folderlist" directory="images" class="input-xxlarge"
            required="true" hide_none="true" hide_default="true" recursive="true"
            label="COM_FIELDS_FIELD_IMAGELIST_DIRECTORY_LABEL"
            description="COM_FIELDS_FIELD_IMAGELIST_DIRECTORY_DESC">
            <option value=""></option>
    </field>
  • Open an article in the back end.
  • Navigate to the options tab.

Expected result

You should see a new select box which lists all folders recursively which are in the images folder.

Actual result

Only the folders below the images folders are shown.

Would be great to get that into 3.6 as it is needed for joomla-projects/custom-fields#97.

avatar laoneo laoneo - open - 4 Jun 2016
avatar laoneo laoneo - change - 4 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 5 Jun 2016
Category Fields
avatar brianteeman brianteeman - test_item - 5 Jun 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Jun 2016

I have tested this item successfully on ad1dfa3


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10722.

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Jun 2016

This works as described.
Just one comment (besides brian's comment).

Before patch we have:

banners
headers
sampledata

After patch i get (notice the slashes):

\banners
\headers
\sampledata
\sampledata\fruitshop
\sampledata\parks
\sampledata\parks\animals
\sampledata\parks\landscape

So, wouldn't it be more consistent with other tree like views in select boxes (ex: menu items) if we have?:

banners
headers
sampledata
- fruitshop
- parks
- - animals
- - landscape


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10722.

avatar brianteeman
brianteeman - comment - 5 Jun 2016

Not sure as this time it refers to a real physical tree not a virtual one.

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Jun 2016

hum, but also remeber we will get huge values if we put the whole tree

avatar brianteeman
brianteeman - comment - 5 Jun 2016

excellent point

On 5 June 2016 at 13:16, andrepereiradasilva notifications@github.com
wrote:

hum, but also remeber we will get huge values if we put the whole tree


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10722 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8Rs2mNpLlu5efZIygUZv0nEvnuKlks5qIr4YgaJpZM4IuGx4
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar joomla-cms-bot
joomla-cms-bot - comment - 6 Jun 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10722.

avatar laoneo
laoneo - comment - 6 Jun 2016

The tree is describing a real path in the Filesystem, so I would show it like that.

I put in the root and the tree was big, but the page got still loaded decently.

avatar brianteeman
brianteeman - comment - 6 Jun 2016

@laoneo I agree and I thought the same at first. But. When you have a very long path eg images/articles/2015/January/finance/blogposts the it probably gets too wide to be usable. Using a tree as proposed resolves that.

avatar Bakual
Bakual - comment - 6 Jun 2016

It's true that it may become more readable in some cases (in others probably not).
However the code change becomes much more complex. Currently, we just use the API and return what we get.

I would leave this PR with the full path like it currently is, and if we want we can change it to a tree later.

avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jun 2016

ok for me

avatar laoneo
laoneo - comment - 6 Jun 2016

Can somebody else test it please?

avatar brianteeman brianteeman - test_item - 6 Jun 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 6 Jun 2016

I have tested this item successfully on 32c9048


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10722.

avatar andrepereiradasilva andrepereiradasilva - test_item - 6 Jun 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jun 2016

I have tested this item successfully on 32c9048


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10722.

avatar brianteeman brianteeman - change - 6 Jun 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 6 Jun 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10722.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 6 Jun 2016
Milestone Added:
avatar laoneo
laoneo - comment - 6 Jun 2016

Thanks!

avatar wilsonge wilsonge - change - 7 Jun 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-06-07 19:42:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 Jun 2016
avatar wilsonge wilsonge - merge - 7 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - close - 7 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment