Do we not need the update sql too?

yes of course, i'm adding .... @zero-24 you know i'm lazy/slow ;)

Ahh sorry i had just saw the first two commits and was wondering ;)

I have tested this item ✅ successfully on 55fb230

I have tested this item ✅ successfully on 55fb230

on code review

I have not tested this item.

on code review

just remind me, shouldn't it be enabled also?

what happens if a user have a disabled com_ajax and them Joomla protectes it on update?

Can he enable it after?

yes - they are not related. Setting an extension to enabled or disabled is
not connected to it being protected. Protected only applies to uninstall

On 1 June 2016 at 10:16, andrepereiradasilva notifications@github.com
wrote:

just remind me, shouldn't it be enabled also?

what happens if a user have a disabled com_ajax and them you protected it?

Can he enable it after?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10701 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8Vxc0dgWBUnaxMSr2DtwrXQIXw0Kks5qHU3ugaJpZM4IrL8z
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

yes i know.
but let's see this usual scenario (i have similiar in a lot of sites).

i have com_ajax disabled in 3.5.1 install. Now i update to 3.6.0. the com_ajax is now protected.

I get something like this in the extension manager (but for com_ajax of course):

Since it was disabled before the update, it still is, but now protected.

So, how do i enable it?

What i mean is: is this scenario don't we end up in a situation that we are protecting a disabled extension?

Ah I see what you mean now. The only option would be directly in the
database AND you have no way of knowing it is disabled

In this case all we have to do is to fix the update statement to make it
enabled AND protected. Setting it to protected without making it enabled
defeats the objective of this PR.

On 1 June 2016 at 11:34, andrepereiradasilva notifications@github.com
wrote:

yes i know.
but let's see thsi usual scenario (i have similiar in a lot of sites).

i have com_ajax disabled. Now i update to 3.6.0 the extension is protected.

I get osmething like this in the extension manager:
[image: image]
https://cloud.githubusercontent.com/assets/9630530/15706640/8e76cf0c-27ec-11e6-859b-cdc9e646d4c1.png

Sicne it was disabled before the update, it still is, but now protected.

So, how do i enable it?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10701 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8dk-6wONO_f3yqa4kYMz9H5-aOnAks5qHWAogaJpZM4IrL8z
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

exactly, thanks

I'll fix the update scripts to set enabled & protected
Thanks for reporting this scenario

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

I have tested this item ✅ successfully on 2e01d57

code review

I have tested this item ✅ successfully on 2e01d57

RTC

Thanks everybody