?
Referenced as Pull Request for: # 10701
avatar mbabker
mbabker
1 Jun 2016

Steps to reproduce the issue

JHtmlBehavior::keepalive() and the stats system plugin have dependencies to com_ajax to utilize them to perform their functions without any checks as to whether the component is even enabled. It'd be equally bad if someone uninstalled it. Code depending on this component should check for its existence as an optional extension and gracefully fail if it is disabled/uninstalled or implement a fallback solution.

Expected result

When com_ajax is disabled or uninstalled, code with dependencies to it should either gracefully fail with a clear warning or implement an alternative way to complete their actions.

Actual result

If disabled, the stats plugin completely fails with no noticeable error to the user (the only indication of trouble is in the browser's dev console when you see the 404 for its com_ajax call). Likewise, if disabled, JHtmlBehavior::keepalive() should not use com_ajax for its AJAX call.

Additional comments

As a non-protected extension, com_ajax can be freely uninstalled and disabled. Prior to 3.5, I had been disabling com_ajax on sites as it wasn't in use (as I do with all sites and core extensions that aren't in use on those sites). By protecting the extension, it prevents uninstallation or disabling it in the UI.

avatar mbabker mbabker - open - 1 Jun 2016
avatar andrepereiradasilva andrepereiradasilva - change - 1 Jun 2016
Category Components
avatar alikon
alikon - comment - 1 Jun 2016

the easy way IMHO should be to protect the com_ajax see #10701

avatar zero-24 zero-24 - change - 1 Jun 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-06-01 05:02:29
Closed_By zero-24
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2016
Closed_By zero-24 joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 1 Jun 2016
avatar zero-24
zero-24 - comment - 1 Jun 2016

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/10700

avatar joomla-cms-bot joomla-cms-bot - close - 1 Jun 2016
avatar brianteeman brianteeman - close - 1 Jun 2016
avatar zero-24
zero-24 - comment - 1 Jun 2016

Closing as we have a PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10700.

avatar brianteeman brianteeman - change - 10 Jun 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment