? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
26 May 2016

Summary of Changes

This PR adds the new JApplicationWeb isHttpsConnection method and deprecates the isSSLConnection method.

This correction of the SSL term to the HTTPS term (the correct one, since HTTPS can use SSL or TLS) was done across Joomla and this PR makes this change in the application method too.

Testing Instructions

This has to be tested by code review.
You can also apply the patch and check everything works fine.

Observations

If someone can look if the unit tests are ok, it would be appreciated.

avatar andrepereiradasilva andrepereiradasilva - open - 26 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
Title
Replace isSSLConnection methos by isHttpsConnection
Replace isSSLConnection method by isHttpsConnection
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
The description was changed
Title
Replace isSSLConnection methos by isHttpsConnection
Replace isSSLConnection method by isHttpsConnection
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 May 2016

@mbabker if ok, i can make a PR for the framework too.

3b4d3a0 26 May 2016 avatar andrepereiradasilva cs
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
The description was changed
avatar brianteeman brianteeman - change - 26 May 2016
Category Libraries Unit Tests
avatar brianteeman brianteeman - change - 26 May 2016
Labels
avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Sep 2016

closing for lack of interest

avatar andrepereiradasilva andrepereiradasilva - change - 5 Sep 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-09-05 21:54:42
Closed_By andrepereiradasilva
Labels

Add a Comment

Login with GitHub to post a comment