Definitely mark it as deprecated if the core isnt using it but as its a library who knows who/what else will be using it so i doubt it can be removed with 100% safety

Suggest to fix the regression caused by 7fcf7f6#diff-98e863dabf8033c2313bc92e9c99cc2f before it hits the streets in J3.6. If not, you'll find out who uses it the hard way. It doesn't work when not fixed.

Agree with mbabker about the poor implementation, would be useful to set the recipient, but unfortunately that requires a change in the API.
Surely extensions implementing desired functionality considered the provided functionality too limited and created their own.

Err what regression? Actually raising errors in JMail and catching
phpmailerExceptions instead of letting them bubble up the stack? Or is my
mobile just not linking to a good spot on that diff?

On Thursday, May 26, 2016, sovainfo notifications@github.com wrote:

Suggest to fix the regression caused by 7fcf7f6
#diff-98e863dabf8033c2313bc92e9c99cc2f
7fcf7f6#diff-98e863dabf8033c2313bc92e9c99cc2f
before it hits the streets in J3.6. If not, you'll find out who uses it the
hard way. It doesn't work when not fixed.

Agree with mbabker about the poor implementation, would be useful to set
the recipient, but unfortunately that requires a change in the API.
Surely extensions implementing desired functionality considered the

provided functionality too limited and created their own.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10629
https://issues.joomla.org/tracker/joomla-cms/10629.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10629 (comment)

Maybe you forgot to change $email into $recipient.
Regression by your change starting at line 722.

folks, looks like this is not related to my report. the method concerned exists for long without any language strings which makes me think it was never used.

Those strings would have to be provided by extensions/overrides wanting to use this function.
Considering you can't just remove it before J4, suggest to fix it.

Oh, whoops. Too much copy/paste.

On Thursday, May 26, 2016, sovainfo notifications@github.com wrote:

Maybe you forgot to change $email into $recipient.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10629 (comment)

In J351 it sends to the site admin email address. Guessing users would want it to go to $email or $recipient as a better name..