? Success

User tests: Successful: Unsuccessful:

avatar vinespie
vinespie
23 May 2016

Pull Request for Issue #9623 .

Summary of Changes

Defer implementation of the script google recaptcha.

Before patch

When you go to single contact page with Internet Explorer, Google Recaptcha does not display all the time.

Testing Instructions

  1. Install joomla 3.5.1 with sample data for testing, apply patch
  2. Publish and configure recaptcha plugin 2016-05-23 13_41_41-joomla 3 - administration - plug-ins _ captcha - recaptcha
  3. Set "Captcha - ReCaptcha" in general configuration, default captcha 2016-05-23 13_43_49-joomla 3 - administration - configuration
  4. With Internet Explorer, go to home page and navigate to "Single contact" 2016-05-23 13_51_26-single contact
  5. Google Recaptcha must be display on contact form after multiple refresh or click on menu.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar vinespie vinespie - open - 23 May 2016
avatar vinespie vinespie - change - 23 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2016
Labels Added: ?
avatar piotr-cz
piotr-cz - comment - 23 May 2016

Which versions of IE are not compatible? I've tested with Edge, v11, v9.
You say that setting the defer attribute solves the problem?

avatar vinespie
vinespie - comment - 23 May 2016

Tested with IE 11 Edge Compatibility View issue #9623

yes, "Defer" attribute solve the problem line 62 :

JFactory::getDocument()->addScript($file, "text/javascript", true);

Generates :
<script src="https://www.google.com/recaptcha/api.js?onload=JoomlaInitReCaptcha2&render=explicit&hl=fr-FR"defer="defer">`

See ReCaptcha documentation
https://developers.google.com/recaptcha/docs/display#explicit_render

avatar piotr-cz
piotr-cz - comment - 23 May 2016

I see. Documentation says that there is another solution: to load the callback first,
so then the code would look like:

JHtml::_('script', 'plg_captcha_recaptcha/recaptcha.min.js', false, true);
JHtml::_('script', $file);

I think I'd prefer this one as the code makes more sense. We could also make an inline comment about script loading order for future reference.
Can test it?

avatar vinespie
vinespie - comment - 23 May 2016

Yes it is possible to do like this.
I use "addScript" because with JHtml script method we can't had "defer" attributes as specified in the recaptcha documentation.
Indeed , I also tested this solution and it fixes the problem.

avatar piotr-cz
piotr-cz - comment - 23 May 2016

Okay, I can actually reproduce the bug in Edge. Changing script order fixes the issue

avatar vinespie
vinespie - comment - 23 May 2016

@piotr-cz , I 've considered your suggestion. Thanks.

avatar mawa7
mawa7 - comment - 23 May 2016

Works like a charm in IE11. Thanks a lot!

avatar brianteeman brianteeman - change - 23 May 2016
Category Plugins
avatar cr2a-graphique cr2a-graphique - test_item - 24 May 2016 - Tested successfully
avatar cr2a-graphique
cr2a-graphique - comment - 24 May 2016

I have tested this item successfully on 2eba9fb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10601.

avatar brianteeman brianteeman - alter_testresult - 24 May 2016 - mawa7: Tested successfully
avatar brianteeman
brianteeman - comment - 24 May 2016

@piotr-cz can you give it one last test please and the I will make this RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10601.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 May 2016

@Fedik since you made the change before. are you ok with this?

avatar Fedik
Fedik - comment - 24 May 2016

unfortunately I do not have IE to test now, but the changes looks good

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 May 2016

ok then. thanks

avatar piotr-cz
piotr-cz - comment - 24 May 2016

@brianteeman How do I mark successful Human Test Result?
btw: in comment above I've tested the patch and issue has been fixed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10601.

avatar brianteeman
brianteeman - comment - 24 May 2016

@piotr-cz you have to do it on the issue tracker not on github

avatar brianteeman brianteeman - change - 24 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 24 May 2016

Thanks everyone RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10601.

avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 24 May 2016
Milestone Added:
avatar piotr-cz piotr-cz - test_item - 24 May 2016 - Tested successfully
avatar piotr-cz
piotr-cz - comment - 24 May 2016

I have tested this item successfully on 2eba9fb

As this is a bugfix and not a feature, can this be included in the current 3.5.x releases and not 3.6?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10601.

avatar brianteeman
brianteeman - comment - 24 May 2016

@piotr_cz the next release is 3.6.0 there wont be another 3.5.x release

On 24 May 2016 at 12:51, Piotr notifications@github.com wrote:

I have tested this item successfully on 2eba9fb
2eba9fb

As this is a bugfix and not a feature, can this be included in the current

3.5.x releases and not 3.6?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10601
https://issues.joomla.org/tracker/joomla-cms/10601.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10601 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar piotr-cz
piotr-cz - comment - 24 May 2016

@zero-24 Yes, but this is for features that were planned for next minor release; IMHO according to semver, bugfixes should be added to current milestone so released as v3.5.2.

Personally I have more confidence in minimizing B/C issues when upgrading from v3.5.1 to v3.5.2 then to v3.6.0.

avatar brianteeman
brianteeman - comment - 24 May 2016

There will NOT be a 3.5.2 release

avatar mbabker
mbabker - comment - 24 May 2016

There isn't a 3.5.2 release. What was going to be 3.5.2 is now 3.6.0.
Short of a major security issue at this point there won't be another 3.5
release.

On Tuesday, May 24, 2016, Piotr notifications@github.com wrote:

@zero-24 https://github.com/zero-24 Yes, but this is for features
that were planned for next minor release; IMHO according to semver,
bugfixes should be added to current milestone so released as v3.5.2.

Personally I have more confidence in minimizing B/C issues when upgrading
from v3.5.1 to v3.5.2 then to v3.6.0.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10601 (comment)

avatar piotr-cz
piotr-cz - comment - 24 May 2016

okay

avatar roland-d roland-d - change - 25 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-25 19:44:06
Closed_By roland-d
avatar roland-d roland-d - close - 25 May 2016
avatar roland-d roland-d - merge - 25 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 May 2016
avatar roland-d roland-d - reference | c50837f - 25 May 16
avatar roland-d roland-d - merge - 25 May 2016
avatar roland-d roland-d - close - 25 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 25 May 2016

Thanks everyone

Add a Comment

Login with GitHub to post a comment