User tests: Successful: Unsuccessful:
Pull Request for Issue #9623 .
Defer implementation of the script google recaptcha.
When you go to single contact page with Internet Explorer, Google Recaptcha does not display all the time.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Tested with IE 11 Edge Compatibility View issue #9623
yes, "Defer" attribute solve the problem line 62 :
JFactory::getDocument()->addScript($file, "text/javascript", true);
Generates :
<script src="https://www.google.com/recaptcha/api.js?onload=JoomlaInitReCaptcha2&render=explicit&hl=fr-FR"
defer="defer">`
See ReCaptcha documentation
https://developers.google.com/recaptcha/docs/display#explicit_render
I see. Documentation says that there is another solution: to load the callback first,
so then the code would look like:
JHtml::_('script', 'plg_captcha_recaptcha/recaptcha.min.js', false, true);
JHtml::_('script', $file);
I think I'd prefer this one as the code makes more sense. We could also make an inline comment about script loading order for future reference.
Can test it?
Yes it is possible to do like this.
I use "addScript" because with JHtml script method we can't had "defer" attributes as specified in the recaptcha documentation.
Indeed , I also tested this solution and it fixes the problem.
Okay, I can actually reproduce the bug in Edge. Changing script order fixes the issue
Works like a charm in IE11. Thanks a lot!
Category | ⇒ | Plugins |
I have tested this item
@piotr-cz can you give it one last test please and the I will make this RTC
unfortunately I do not have IE to test now, but the changes looks good
ok then. thanks
@brianteeman How do I mark successful Human Test Result?
btw: in comment above I've tested the patch and issue has been fixed
Status | Pending | ⇒ | Ready to Commit |
Thanks everyone RTC
Labels |
Added:
?
|
Milestone |
Added: |
I have tested this item
As this is a bugfix and not a feature, can this be included in the current 3.5.x releases and not 3.6?
@piotr_cz the next release is 3.6.0 there wont be another 3.5.x release
On 24 May 2016 at 12:51, Piotr notifications@github.com wrote:
I have tested this item
✅ successfully on 2eba9fb
2eba9fbAs this is a bugfix and not a feature, can this be included in the current
3.5.x releases and not 3.6?
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10601
https://issues.joomla.org/tracker/joomla-cms/10601.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10601 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@zero-24 Yes, but this is for features that were planned for next minor release; IMHO according to semver, bugfixes should be added to current milestone so released as v3.5.2.
Personally I have more confidence in minimizing B/C issues when upgrading from v3.5.1 to v3.5.2 then to v3.6.0.
There will NOT be a 3.5.2 release
There isn't a 3.5.2 release. What was going to be 3.5.2 is now 3.6.0.
Short of a major security issue at this point there won't be another 3.5
release.
On Tuesday, May 24, 2016, Piotr notifications@github.com wrote:
@zero-24 https://github.com/zero-24 Yes, but this is for features
that were planned for next minor release; IMHO according to semver,
bugfixes should be added to current milestone so released as v3.5.2.Personally I have more confidence in minimizing B/C issues when upgrading
from v3.5.1 to v3.5.2 then to v3.6.0.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10601 (comment)
okay
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-25 19:44:06 |
Closed_By | ⇒ | roland-d |
Labels |
Removed:
?
|
Thanks everyone
Which versions of IE are not compatible? I've tested with Edge, v11, v9.
You say that setting the defer attribute solves the problem?