[#10600] - Fix APC for when internal key name is entry_name
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10600
- Diff
- photodude:patch-6
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Part of Issue #10220
Summary of Changes
Some APC(u) modules changed the internal key name from key to entry_name. HHVM is one such case where the APC module uses a different naming.
This addresses the 3 known types of keys for APC(u)
Testing Instructions
Merge by code review.
Passing test with var_dump of the entries in our unit tests showing HHVM apc key name is entry_name https://travis-ci.org/photodude/joomla-cms/jobs/132170969
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Cache Libraries |
Seems odd they would use an outdated/abandoned PHP extension but ¯\_(ツ)_/¯
About as odd as why they installed memcache and memcached in the default settings.
Is there any interest in moving forward with this PR?
I'd say it should be merged. If it's gonna sit and wait for people who have PHP environments with APC(u) to come along and test it's going to go nowhere.
| Status | Pending | ⇒ | Ready to Commit |
RTC on Review. For 3.6.1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10600.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 06:43:07 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
APCu probably needs to be checked too.