Feeling Lucky
?
[#10564] - Fix "Cancel" button not closing modal images
- Fixed in Code Base
- 21 May 2016
- Medium
- Build: staging
- # 10564
- Diff
- JoomliC:Fix-cancel-button-not-closing-modal
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue reported (and confirmed in 3.5.1) by @roland-d : #10522 (comment)
Summary of Changes
- Add
window.parent.jModalClose()toonclickfor cancel button
Testing Instructions
- Open a select image modal (for example, in Article edit, intro image)
- Click on "Cancel" button.
- Before Patch: modal does not close
- After Patch: modal closes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
Cybernary
- comment
- 21 May 2016
I have tested this item
Tested on 05-21-2016 and worked fine.
Went to edit an article, opened the images modal window and used the Cancel button to close the window.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10564.
MATsxm
- comment
- 21 May 2016
I have tested this item
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10564.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 21 May 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-21 16:04:43 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 2cdb2f1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10564.