Feeling Lucky
?
[#10560] - Fix loading iframe in modal (issue reported here https://github.com/j…
- Fixed in Code Base
- 21 May 2016
- Medium
- Build: staging
- # 10560
- Diff
- JoomliC:Fix-iframe-loading-inside-modals
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
Pull Request for
# 10557
User tests: Successful: Unsuccessful:
Pull Request for Issue reported by @roland-d : #10557 (comment).
When I click the Edit button the modal comes up and I first see the article list which then changes to the edit page.
Why is the article list shown before the edit screen? I would expect the edit screen without seeing the article list first.
Summary of Changes
- When an iframe is loaded inside a modal, this one is destroyed first and then reloaded to use then Jlayout modal iframe, but it could return the issue reported (see Testing Instructions before patch, or @roland-d comment above) when the script is included in modal event handler "shown".
- Adding the iframe rendering inside a "show" event (before the modal has been made visible to the user), solves this issue.
Testing Instructions
Before Patch:
- Open any Edit modal (article, category, module, contact, newsfeed) : can be found in menu item type "Single ****" or in association tab of article, category, newsfeed, contact edit page
- After click on "Edit" button (the layout loads directly) click on "Close"
- Then click again on "Edit" button, and you may see the list view 1/2 second before the edit layout loads.
After Patch:
- Do the same: the edit layout loads each time directly, and the list (contacts, articles...) does not show up anymore before edit view
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Layout |
| Rel_Number | 0 | ⇒ | 10557 |
| Relation Type | ⇒ | Pull Request for |
pete-rossetti
- comment
- 21 May 2016
Yup have tested this patch successfully - the delay in filling the modal is removed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10560.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 21 May 2016
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-21 16:14:17 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
zero-24
- comment
- 22 May 2016
@brianteeman @roland-d can we get the milestone here?
| Milestone |
Added: |
||
brianteeman
- comment
- 22 May 2016
Done
I have tested this item✅ successfully on 6ded0a7
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10560.