[#10557] - Modal com_content: improve Select & Edit Article (Update)
- Fixed in Code Base
- 20 May 2016
- Medium
- Build: staging
- # 10557
- Diff
- JoomliC:Modal-com_content-improve-Select-&-Edit-Article
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Improve modals to select and to edit an article. (Update for PR #10292 (merged in staging) + patch PR 10522)
Note: to be testing on staging.
Summary of Changes
- Control if modal, in edit layout
- Add
Save(keep modal open),Save & CloseandClosebutton to the footer of the modal - Fix closing of Modal when edit validation returns an error (does not close the modal, and display alert message in modal)
- Add function to update input title when changed
- A few code improvements (simplify)
Testing Instructions (Staging + Multilanguages enabled!)
- Go to Content > Articles > open an article, and go to
Associationstab to select associated article to open the modal. - Select an associated article and save the article to show edit button
- Click on Save and Save & Close with a correct edition (no error), and then with an empty title, or any other possible error (not filled required field).
- Expected behavior: If an error, Save & Close won't close the modal, and Save will never close the modal (close only when requested, and on successful edition)
- Edit an article in modal, change title, and save and close : the title in the input field should be then updated with the new title.
- Do the same in a menu item type "Single Article", for Select and Edit article.
Same rendering as for Categories in PR #10441 (screenshots)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I have tested this item
Tested successfully on a multilanguage setup.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10557.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10557.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10557.
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Components |
| Labels | |||
| Milestone |
Added: |
||
@JoomliC The code does what it says but there is an issue. When I click the Edit button the modal comes up and I first see the article list which then changes to the edit page.
Why is the article list shown before the edit screen? I would expect the edit screen without seeing the article list first.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10557.
| Status | Ready to Commit | ⇒ | Information Required |
| Labels | |||
Taking off RTC for now as there is a UI issue.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10557.
| Labels |
Removed:
?
|
||
@roland-d This is not related to this PR!!!
Test with module edit modal (this is one modal i have not yet refactoried ;-) ) (menu -> edit menu item -> modules assignment -> click on one module name to edit : first click good, close, click again on edit and same issue).
This happens with all modals using edit layout, and i have a bit of an idea about this ;-)
So, will work on a global fix for all in a separate PR
modal-footer should float left imho in RTL.
@infograf768 This could be done i think... will check it later (still some work to do on some modals ;-) ) as it may be in bootstrap library itself...
@roland-d Which modal footer fix ?!? :-|
If you mean @infograf768 comment on RTL position for booter buttons, not related to this PR, as this is a global bootstrap library issue, not related to this specific PR...
| Status | Information Required | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-20 12:28:34 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
@infograf768 Well, great! So i let you do this one, and will keep focusing on other modals ;-)
Thank you!
And thanks all for testing!
@roland-d PR created for the issue with "list" loaded shortly before edit layout : #10560 cc/ @andrepereiradasilva @infograf768 @BurtNL
;-)
I have tested this itemā
successfully on 88e401b
Works great! thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10557.