? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
18 May 2016

Pull Request for Issue #10540

This does not need to be tested on a multilang site.
Test instructions:

Edit the System Language Code plugin and enable it, save.
After save, a new tab "Language Codes" will show.
Enter fr-CA for example (if your default site language is fr-FR)

screen shot 2016-05-18 at 08 49 11

Save and close.

Display an article in frontend and look at source:

Instead of
<meta itemprop="inLanguage" content="fr-FR" />
you will now correctly get
<meta itemprop="inLanguage" content="fr-CA" />

avatar infograf768 infograf768 - open - 18 May 2016
avatar infograf768 infograf768 - change - 18 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2016
Labels Added: ?
avatar infograf768 infograf768 - change - 18 May 2016
Title
…
Displaying correct itemprop language when modified by languagecode
Displaying correct itemprop language when modified by the languagecode plugin
avatar infograf768 infograf768 - change - 18 May 2016
Title
…
Displaying correct itemprop language when modified by languagecode
Displaying correct itemprop language when modified by the languagecode plugin
avatar infograf768 infograf768 - change - 18 May 2016
Category ⇒ Front End Multilanguage
avatar brianteeman
brianteeman - comment - 18 May 2016

Isnt the correct thing to do to install the fr-CA language pack?

On 18 May 2016 at 07:51, infograf768 notifications@github.com wrote:

Pull Request for Issue #10540
#10540

This does not need to be tested on a multilang site.
Test instructions:

Edit the System Language Code plugin and enable it, save.
After save, a new tab "Language Codes" will show.
Enter fr-CA for example (if your default site language is fr-FR)

[image: screen shot 2016-05-18 at 08 49 11]
https://cloud.githubusercontent.com/assets/869724/15349748/777d5fc2-1cd5-11e6-9729-44315f0eda69.png

Save and close.

Display an article in frontend and look at source:

Instead of

you will now correctly get

You can view, comment on, or merge this pull request online at:

#10542
Commit Summary

  • Displaying correct itemprop language when modified by languagecode

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10542

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 18 May 2016

@brianteeman
The fr-CA example is just an example.
I could have used fr-CH for the demonstration. Or en-HK for English (Hong Kong).
This is the fundamental usage of the language code plugin.

avatar brianteeman
brianteeman - comment - 18 May 2016

Ah - ok - good point - thanks for the explanation

On 18 May 2016 at 08:26, infograf768 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman
The fr-CA example is just an example.
I could have used fr-CH for the demonstration. Or en-HK for English (Hong
Kong).
This is the fundamental use of the language code plugin.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10542 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 18 May 2016

Thank you for testing. :smiley:

avatar brianteeman brianteeman - test_item - 18 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 May 2016

I have tested this item :white_check_mark: successfully on 17ab1e6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10542.

avatar andrepereiradasilva andrepereiradasilva - test_item - 18 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 18 May 2016

I have tested this item :white_check_mark: successfully on 17ab1e6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10542.

avatar brianteeman brianteeman - change - 18 May 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 18 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10542.

avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 18 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 18 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-18 10:28:05
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 18 May 2016
avatar wilsonge wilsonge - merge - 18 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 18 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment