? Success

User tests: Successful: Unsuccessful:

avatar ggppdk
ggppdk
18 May 2016

Issue

The onContentPrepare event triggering on the contact view has no effect

Summary of Changes

Trigger onContentPrepare event on proper property ($item->misc)

Testing Instructions

  1. Edit a contact
  2. Go to "Miscellaneous Information" TAB
  3. Add plugin text of some content plugin that does not limit itself into some specific component / view
  4. View the contact in frontend , the plugin text is replaced ...
avatar ggppdk ggppdk - open - 18 May 2016
avatar ggppdk ggppdk - change - 18 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2016
Labels Added: ?
avatar ggppdk ggppdk - change - 18 May 2016
The description was changed
avatar ggppdk ggppdk - change - 18 May 2016
The description was changed
avatar ggppdk ggppdk - change - 18 May 2016
The description was changed
avatar ggppdk ggppdk - change - 18 May 2016
The description was changed
avatar ggppdk ggppdk - change - 18 May 2016
The description was changed
avatar andrepereiradasilva
andrepereiradasilva - comment - 18 May 2016

"Add plugin text of some content plugin that does not limit itself into some specific component / view"

can you provide examples of this?

avatar ggppdk ggppdk - change - 18 May 2016
The description was changed
avatar ggppdk
ggppdk - comment - 18 May 2016

Thanks, an example, add these 2 cases

  • text for content/loadmodule.php plugin
  • text for content/emailcloak.php plugin
{loadmodule mod_banners,Banners}
sometest@sometestdom.com

You will see that
1 . the banner module gets added (or at least it disappears, if module is not found)
2 . the email gets cloaked (becomes a link, and if you examine the HTML you will see the cloaking code)

avatar andrepereiradasilva andrepereiradasilva - test_item - 18 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 18 May 2016

I have tested this item :white_check_mark: successfully on 7fc838a

Works as described.

BTW can you similar PR also for the cases described in #10539 (tags, etc)?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10541.

avatar brianteeman brianteeman - change - 18 May 2016
Category Plugins
avatar ghazal ghazal - test_item - 22 May 2016 - Tested successfully
avatar ghazal
ghazal - comment - 22 May 2016

I have tested this item successfully on 7fc838a

I am kind of relieved that you found a working solution.
I was the one who pointed the bug out.
But I think the feature is useful and it would have been a pity to remove it.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10541.

avatar ggppdk
ggppdk - comment - 22 May 2016

@andrepereiradasilva , @ghazal

thanks for testing

Now about:

BTW can you similar PR also for the cases described in #10539 (tags, etc)?

For tags view, the content plugin triggering is already working well in both

  • description of the tag
  • description of the articles

so there is nothing to fix at list in for tags view

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 May 2016

did you tried /component/tags/ url?

avatar brianteeman brianteeman - change - 23 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 23 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10541.

avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 23 May 2016
Milestone Added:
avatar brianteeman brianteeman - change - 23 May 2016
Milestone Added:
avatar roland-d roland-d - change - 23 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-23 12:45:39
Closed_By roland-d
avatar roland-d roland-d - close - 23 May 2016
avatar roland-d roland-d - merge - 23 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 23 May 2016
avatar roland-d roland-d - reference | 0a98dbe - 23 May 16
avatar roland-d roland-d - merge - 23 May 2016
avatar roland-d roland-d - close - 23 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 23 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment