Feeling Lucky
?
[#10535] - [com_newsfeeds] Coding standards form xml + correction wrong closing tags
- Closed
- 17 May 2016
- Medium
- Build: staging
- # 10535
- Diff
- JoomliC:Coding-standards-com_newsfeed-XML
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Code standards (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md) + correction closing tags, form xml files com_newsfeeds
Summary of Changes
config.xml
- Code standards
- Add emtpy line before each opening tag (readability)
- Fix mix space/tabs for a few indents
newsfeeds.xml
- Remove extra empty line at end of xml file
models/forms/newsfeed.xml
- Code standards
- Add emtpy line before each opening tag (readability)
- Fix wrong field closing tags :
catid&tags
models/forms/filter_newsfeeds.xml
- Add emtpy line before each opening tag (readability)
Testing Instructions
- code review
- apply and test all is working as before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-17 18:40:12 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
I have tested this item
successfully on d3e1309
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10535.