?
avatar Webdongle
Webdongle
14 May 2016

Steps to reproduce the issue

Menu >>> hover over a menu >>> click to create a menu
Click Cancel or finish creating the menu ... save and click Close

Expected result

Page returns to administrator/index.php?option=com_menus

Actual result

Page returns to administrator/index.php?option=com_menus&view=items&menutype= with a 403 error

System information (as much as possible)

Tested on live site and xampp localhost

Additional comments

If you have (during admin session) already visited administrator/index.php?option=com_menus&view=items&menutype=menuname ... then Cancel or Close will return to that page. Otherwise it returns to administrator/index.php?option=com_menus&view=items&menutype= with a 403 errorscreen shot 2016-05-14 at 07 29 05

avatar Webdongle Webdongle - open - 14 May 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

confirmed.
@infograf768 the one i talked about.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

IMHO we shouldn't use '*' to identify the no menu item selection, just '' (empty string) like all other filters..

avatar Webdongle
Webdongle - comment - 14 May 2016

It used to return to
administrator/index.php?option=com_menus
and displayed the first menu alphabetically. Now it returns to
administrator/index.php?option=com_menus&view=items&menutype=
and appends a menu name only if a menu has previously been visited during that login session.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

@Webdongle please test #10459

Please notice that #10459 only solves a part of this issue (the 403 error)

The other part (wrong redirect after creating a menu item i think it's another thing)

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

Confirmed.
The second subissue in this issue (the wrong redirect) already exists in 3.5.1.

It seems when we open the select menu type modal we lose the menutype=xxxxxx in the URL.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

You check that issue with this:
1. Use 3.5.1
2. Logout from backend
3. Login in the backend
4. Go directly to the admin menu Menus -> Any Menu -> Add new menu item
5 .Notice the URL in the new/edit menu item page (&menutype=xxxxxx)
6. Now press select menu item and select one menu item type and close
7 .Notice the URL in the new/edit menu item page (no &menutype=xxxxxx)

Notice the URL is not the problem itself, the menu where we are should be saved on open the new/edit menu page. I will try to check this also.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

ok second PR to solve the redirect issue #10460

Please test.

avatar Webdongle Webdongle - change - 14 May 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-05-14 16:33:37
Closed_By Webdongle
avatar Webdongle Webdongle - close - 14 May 2016
avatar Webdongle Webdongle - close - 14 May 2016
avatar Webdongle
Webdongle - comment - 14 May 2016

#10460 solves this issue so closed

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

@Webdongle #10460 doesn't solve the two issues.

Even with #10460 if you go to /administrator/index.php?option=com_menus&view=items&menutype= you get the 403 error.

Thast's why i also created #10459. Please test.

avatar Webdongle
Webdongle - comment - 14 May 2016

@andrepereiradasilva

Now I am lost ... administrator/index.php?option=com_menus&view=items&menutype= was the url that was reached after clicking Cancel or Close in the menu item. It was not typed in directly.

When #10460 is applied then clicking Cancel or Close in the menu item returns to administrator/index.php?option=com_menus&view=items&menutype=menuname. That fixes this issue ... the issue never occurred when the 'menu items' on the side bar had been visited. So to test #10458 prevents this error from happening even before that patch is applied because the test instructions require the 'menu items' on the side bar is visited

However #10460 can be tested without visiting the 'menu items' on the side bar and can be tested for this issue. I have tested and it fixes this issue.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

#10460 fixes this issue itself, because you don't have anymore the /administrator/index.php?option=com_menus&view=items&menutype= URL directly on joomla (that i know of). In other words the problem is masked.

#10459 fixes the issue one step further by allowing to use that URL without a 403 as a fallback (in case the menu type is not found or something) to the all menu items list view.

avatar Webdongle
Webdongle - comment - 14 May 2016

"#10459 fixes the issue one step further by allowing to use that URL without a 403 as a fallback (in case the menu type is not found or something) to the all menu items list view"

Ah but before the issue began >>> navigating Menus ... hover over menu ... select create new menu ... then cancel or close ... never didn't look for anything in 'all menu items list view'. It just returned to administrator/index.php?option=com_menus&view=items ... it didn't look for for anything with &menutype=

This issue was about the url that the close/cancel returned to was incorrect so #10460 fixes this. _#10459 is separate because it deals with handling the wrong url not replacing it. Will test later but can't reproduce the issue following the test instructions it has.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

You're right #10460 solves the issue described here.

Will test later but can't reproduce the issue following the test instructions it has.

Thanks. Updated test instructions and title to remove the link to this issue.

Add a Comment

Login with GitHub to post a comment