[#10457] - Modal com_contact: improve Select & Edit Contact
- Fixed in Code Base
- 16 May 2016
- Medium
- Build: staging
- # 10457
- Diff
- JoomliC:modal-com_contacts-improve-select-&-edit-contact
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Improve modals to select and to edit a contact.
Note: to be testing on staging.
Summary of Changes
- When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2). This PR sets the tooltip placement to bottom to fix this issue.
- Remove inline CSS
- Content is embedded in a container div (using already existing container-popup class for modal.php)
- Add empty lines to improve the readability
- Add viewport dimensions (new
3.6.0-dev) - Contact edit modal is simplified (load edit layout, so no dupplicated code)
- Fix Edit button when current associated contact in data is not the selected contact
- Control if modal, in edit layout
- Add
Save(keep modal open),Save & CloseandClosebutton to the footer of the modal - Fix Edit modal not opening as a modal (missing bootstrap.renderModal for Edit modal)
- Fix consistency of fieldsets
$this->ignore_fieldsets, and add missing tabs, and remove dupplicated fieldset metadata (as using now correct edit view inside the modal) - Consistency of language string
COM_CONTACT_EDIT_CONTACTwith other components (com_content, com_categories...) : "Edit Contact" and not "Contact".
Testing Instructions (Staging + Multilanguages enabled!)
- Go to Components > Contacts > open a contact, and go to
Associationstab to select associated contact to open the modal. - Verify tooltip placement is bottom, and not truncated
- Verify the modal size now is proportionnal to viewport (modal is 80/100th viewport width, and modal-body is 70/100th viewport height)
- Select an associated contact and save the contact to show edit button
- Open Edit modal and play with it ;-)
- Do the same in a menu item type "Single contact", for Select and Edit contact.
Same rendering as for Categories in PR #10441 (screenshots)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
just an additional info, this modals also exists in menu item -> single contact (you don't need multilanguage there to test).
just an additional info, this modals also exists in menu item -> single contact (you don't need multilanguage there to test).
Yes, you don't need multilanguage there, but it's good to test both places where those modals are used ;-) (as in menu, "clear" is not allowed by field attribute, but is allowed (as associated contact is optional) in associations).
So, only on multilanguage, you will be able to test the "clear" button.
| Category | ⇒ | Components |
| Labels | |||
I have tested this item 
successfully on 9f26ce1
Installed the latest staging and setup a multilangual website.
All works as described, great!
Will you do the same for the Contacts Categories?
I'll be happy to test that too!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.
I have tested this item successfully on 9f26ce1
Works great - Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.
That one is already done #10441
Confirmed!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 15:54:59 |
| Closed_By | ⇒ | rdeutz |
That i know of, only in Menus -> Manage (modules button in "Linked Modules")
There are the same modals as for the assignment modules in menu edition.
And it is in 3.5 the only edit modal opening in a modal. In fact, i based all work done for 3.6.0 on this one ;-)
I'm currently working on newsfeeds modal, and the next one will be modules with only a few improvements, to have consistence with already edit modals done : category and contact.
Edit article was done, but will do too a new PR just to add the Save button there too, and to use same file structure as done here ;-)
So, still in process, but good to point me this location for where module edit is used too! 
| Labels |
Removed:
?
|
||
Thanks @andrepereiradasilva @BurtNL @MATsxm for testing
Just opened a PR for com_newsfeeds modal (with same testing instructions and expected results) ;-)
#10516
I have tested this item
successfully on 9f26ce1
Nice work yet again.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.