Feeling Lucky
?
[#10442] - SEF for feeds
- Fixed in Code Base
- 4 Jun 2016
- Medium
- Build: staging
- # 10442
- Diff
- andrepereiradasilva:sef-for-feeds
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
Pull Request for
# 7437
User tests: Successful: Unsuccessful:
Pull Request for Issue #7437.
Summary of Changes
This PR adds the SEF plugin conversion to rss/atom feeds.
Before
After
Testing Instructions
- Use latest staging
- Create a Category List or blog menu item to list a category
- Edit one of the articles of that category and add some internal links (+Article in editor) and images.
- Ativate SEF system plugin and SEF in global config
- Go to frontend to the category page (created at 1). Check all internal URL are converted to SEF URL
- Add
?type=rss&format=feedto the category URL to view the feed. - Notice the URL are not SEF in the feed.
- Apply patch
- Repeat step 5 and 6, notice the feed internal URL are now converted to SEF URL.
- Do a general test to check if the SEF URL are working properly in the site and nothing is broken.
- Test also with different combinations of SEF in global config and with/without multilanguage (language filter plugin).
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 7437 |
| Relation Type | ⇒ | Pull Request for |
| Category | ⇒ | Components Router / SEF |
alikon
- comment
- 28 May 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10442.
andrepereiradasilva
- comment
- 29 May 2016
@brianteeman RTC here?
wojsmol
- comment
- 29 May 2016
@andrepereiradasilva github see conflicts here.
andrepereiradasilva
- comment
- 30 May 2016
right, you're code style review. Will fix them.
joomla-cms-bot
- comment
- 30 May 2016
This PR has received new commits.
CC: @alikon, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10442.
andrepereiradasilva
- comment
- 30 May 2016
conflicts fixed (just added two lines of spaces before and after the foreach cycle)
brianteeman
- comment
- 2 Jun 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10442.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 2 Jun 2016
Setting RTC based on tests before last update which was cometic only
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10442.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-04 08:58:22 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 4 Jun 2016
Thanks everybody
I have tested this item
successfully on acc297d
tested sef and non sef and it works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10442.