[#10441] - Modal com_categories: improve Select & Edit Category
- Fixed in Code Base
- 16 May 2016
- Medium
- Build: staging
- # 10441
- Diff
- JoomliC:modal-com_categories-improve-select-category
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Improve modals to select and to edit a category.
Note: to be testing on staging.
Summary of Changes
- When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2). This PR sets the tooltip placement to bottom to fix this issue.
- Remove inline CSS
- Content is embedded in a container div (using already existing container-popup class for modal.php)
- Add empty lines to improve the readability
- Add viewport dimensions (new
3.6.0-dev) - Category edit modal is simplify (loading edit layout, so no dupplicated code)
- Fix Edit button when current associated category in data is not the category selected
- Control if modal, in edit layout
- Add Save, Save & Close and Close button to the footer of the modal
- Fix Edit modal not opening as a modal (missing bootstrap.renderModal for Edit modal)
- Fix
Uncaught SyntaxError: Unexpected token )in select category modal
Testing Instructions (Staging + Multilanguages enabled!)
- Go to Contents > Categories > open a categorie, and go to
Associationstab to select associated category to open the modal. - Verify tooltip placement is bottom, and not truncated
- Verify the modal size now is proportionnal to viewport (width 80/100th viewport width, and modal-body is 70/100th viewport height)
- Select an associated category and save the category to show edit button
- Open Edit modal and play with it ;-)
Select Category Before Patch
Select Category After Patch
Edit Category Before Patch
Open in a new window...
Edit Category After Patch
Open in a modal
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
ups, the js error is already there without your PR ..., so tested with success
I have tested this item 
successfully on d738268
as said js error was already there so this PR does what is proposed to do.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.
@andrepereiradasilva yes error was there before, but prepare yourself for a new test, as i will fix it (this PR is a good occasion to fix issue!) ;-)
| Category | ⇒ | Components UI/UX |
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.
@andrepereiradasilva JS error is now fixed here : 96e2bb0
But, i will put this PR in stand-by until tomorrow, as i will see to add directly in this PR, the modal to edit category and do a 2-in-1 PR for modals select and edit category ;-)
ok will wait then.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.
@andrepereiradasilva That's ok!
- Issue Fixed
- And PR for both Select and Edit category modals ;-)
Ready for testing! (and to be then the base for other ones, if all is ok!)
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
I have tested this item successfully on 443897d
Tested with success.
Solves a lot of issues with the "Edit" modal, js errors and the "Clear" button.
Also now the "Edit" is a modal with "Close", "Save" and "Save & Close" buttons! 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.
Thank you @andrepereiradasilva !
Yes, if this one for category is ok, i will update article and module (with save button) and will do the ones for contact and newsfeed.
I think i can do this for 3.6.0 ;-)
I have tested this item successfully on 443897d
Everything works as described. Great!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
@andrepereiradasilva @BurtNL Thanks for testing!
A new one just added for com_contacts #10457 ;-)
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 16:22:31 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
in the modal, got a JS error
Uncaught SyntaxError: Unexpected token )on selecting a category.BTW did you notice the lack of modal in the "Edit" button (the button appears after saving the category with the association)?