[#10438] - [lib & admin & template & plugins] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
- Closed
- 17 May 2016
- Medium
- Build: staging
- # 10438
- Diff
- zero-24:patch-33
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10399 .
Summary of Changes
Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
Testing Instructions
Please do a code review or test all changed files.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
I have tested this item 
successfully on 6aa2082
on review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
@brianteeman please remove the RTC from this one. It as errors.
Please explain the errors - saying it is not correct is not helpful
htmlspecialchars($image->data), ENT_COMPAT, 'UTF-8'
should be
htmlspecialchars($image->data, ENT_COMPAT, 'UTF-8)'
Explain not quote ;)
the parentisis is the wrong place
travis is also telling that.
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
RTC removed as requested
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.
| Labels |
Removed:
?
|
||
@zero-24 see zero-24#12
This PR has received new commits.
CC: @alikon, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.
seems all fine to me now.
This PR has received new commits.
CC: @alikon, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.
Thanks @wojsmol & @andrepereiradasilva
I have tested this item successfully on 22ff770
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.
I have tested this item successfully on 22ff770
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
This PR has received new commits.
CC: @alikon, @andrepereiradasilva, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.
i did broken my branch please remove the milestone. @brianteeman
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-17 17:58:36 |
| Closed_By | ⇒ | zero-24 |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
I have tested this item
successfully on 6aa2082
on review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10438.