? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
12 May 2016

Pull Request for Issue #10399 .

Summary of Changes

Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')

Testing Instructions

Please do a code review or test all changed files.

avatar zero-24 zero-24 - open - 12 May 2016
avatar zero-24 zero-24 - change - 12 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 12 May 2016
Category Code style
avatar brianteeman brianteeman - test_item - 12 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 May 2016

I have tested this item :white_check_mark: successfully on 0898f7f

On review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

avatar alikon alikon - test_item - 12 May 2016 - Tested successfully
avatar alikon
alikon - comment - 12 May 2016

I have tested this item :white_check_mark: successfully on 0898f7f

it's quite strange that travis is unhappy with @zero-24 :eyes:

tested on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

avatar brianteeman brianteeman - change - 12 May 2016
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 12 May 2016
Milestone Added:
avatar brianteeman
brianteeman - comment - 12 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 12 May 2016

I'm going to fix it tomorrow. It is an too much char per line error :(

avatar brianteeman brianteeman - change - 12 May 2016
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 12 May 2016

Remove RTC for now

avatar brianteeman brianteeman - change - 12 May 2016
Status Ready to Commit Pending
Labels
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Milestone Removed:
avatar brianteeman
brianteeman - comment - 12 May 2016

remove milestone for now

avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 13 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 13 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 May 2016
Milestone Added:
avatar joomla-cms-bot
joomla-cms-bot - comment - 13 May 2016

This PR has received new commits.

CC: @alikon, @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10437.

avatar rdeutz rdeutz - change - 16 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-16 16:17:07
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 May 2016
avatar rdeutz rdeutz - merge - 16 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment