Feeling Lucky
?
[#10428] - [com_content] modal article edit: Fix for TypeError: window.parent is null
- Fixed in Code Base
- 16 May 2016
- Medium
- Build: staging
- # 10428
- Diff
- JoomliC:patch-30
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9935 (comment) .
Summary of Changes
- Close control was added in bootstrap.renderModal in PR #10292 : https://github.com/joomla/joomla-cms/pull/10292/files#diff-cbe64e5e6a231b8b275d55b5c6c00942R206
- For this reason, this PR removes script to control close inside the modal.php view (not needed anymore, and duplicated task)
- In the same time, fix the TypeError returned by console
Testing Instructions
With console error opened, on latest staging.
- Test in Menus > Menu Item type "single article" > Edit article to open the modal to edit article
- Then click CLOSE button of the modal
- Go to Articles : Check that the article is not locked (the article edition was well closed)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Components UI/UX |
andrepereiradasilva
- comment
- 12 May 2016
travis error is because of a long line in this commit (c2de752#diff-4287911d5dd8bdce36df239fa55d6b33R619). Just CS
Unrelated to this PR
andrepereiradasilva
- comment
- 12 May 2016
I have tested this item 
successfully on 7cbbd7d
Tested and no javascript error on Close the module now.
Travis error is unrelated to this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10428.
BurtNL
- comment
- 12 May 2016
I have tested this item successfully on 7cbbd7d
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10428.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 12 May 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 21:54:48 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 16 May 2016
Thanks everybody
@mbabker I don't understand why Travis fails in this PR, about this : c2de752#diff-4287911d5dd8bdce36df239fa55d6b33R619
