Joomla! Issue Tracker | Joomla! CMS #10427 - [com_modules] modal module edit: Fix for TypeError: window.parent is null

?

Fixed in Code Base
12 May 2016
Medium
Build: staging
# 10427
Diff
JoomliC:patch-29

Failure

Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

JoomliC
11 May 2016

Pull Request for Issue #9935 (comment) .

Summary of Changes

Close control was added in bootstrap.renderModal in PR #10317 : https://github.com/joomla/joomla-cms/pull/10317/files#diff-7488449cc92aded23bb5f4abdac5ca91R146
For this reason, this PR removes script to control close inside the modal.php view (not needed anymore, and duplicated task)
In the same time, fix the already existed TypeError returned by console! ;-)

Testing Instructions

With console error opened, on latest staging.

Go to menus, and open one menu item
Click on one of the module in "Module Assignment" tab, to open the module edition
Then click CLOSE button of the modal
Go to Modules Manager : Check that now the module is not locked (the module edition was well closed)

89e2ef8 11 May 2016

Check out in case of modal close not needed anymore (set in bootstrap.renderModal)

JoomliC - open - 11 May 2016

JoomliC - change - 11 May 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 11 May 2016

Labels

Added: ?

BurtNL - test_item - 12 May 2016 - Tested successfully

BurtNL - comment - 12 May 2016

I have tested this item successfully on 89e2ef8

Works as described in #10317 and error TypeError is fixed now.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10427.}

BurtNL - comment - 12 May 2016

Oh, I just see there was an error with Travis, will retest when that is solved.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10427.}

zero-24 - comment - 12 May 2016

@burtnl travis fails unrealted to this PR. It looks like a issue in the main repo.

brianteeman - change - 12 May 2016

Category

⇒

Components UI/UX

andrepereiradasilva - test_item - 12 May 2016 - Tested successfully

andrepereiradasilva - comment - 12 May 2016

I have tested this item successfully on 89e2ef8

Tested and no javascript error on Close the module now.

Travis error is unrelated to this PR.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10427.}

wilsonge - change - 12 May 2016

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2016-05-12 11:51:21
Closed_By		⇒	wilsonge

wilsonge - close - 12 May 2016

wilsonge - merge - 12 May 2016

wilsonge - reference | ae81589 - 12 May 16

wilsonge - merge - 12 May 2016

wilsonge - close - 12 May 2016

wilsonge - change - 12 May 2016

Milestone

Added:

wilsonge - comment - 12 May 2016

Merged - thanks!

Add a Comment

Login with GitHub to post a comment

Older
Newer