? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
11 May 2016

Pull Request for Issue #10399 .

Summary of Changes

Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')

Testing Instructions

  • Enable the mod_login module to the frontend
  • see that it works (login)
  • see that it works (logout)
  • apply this patch
  • see that it works (login)
  • see that it works (logout)
avatar zero-24 zero-24 - open - 11 May 2016
avatar zero-24 zero-24 - change - 11 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 11 May 2016
Category Code style
avatar brianteeman brianteeman - test_item - 11 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 May 2016

I have tested this item :white_check_mark: successfully on 8a3e663


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar BurtNL BurtNL - test_item - 12 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 12 May 2016

I have tested this item :white_check_mark: successfully on 8a3e663


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar brianteeman brianteeman - change - 12 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 12 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 12 May 2016
Milestone Added:
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 May 2016

@brianteeman same thing. Please remove the RTC.

avatar wojsmol
wojsmol - comment - 14 May 2016
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 May 2016

This PR has received new commits.

CC: @brianteeman, @BurtNL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar zero-24 zero-24 - change - 14 May 2016
Status Ready to Commit Pending
avatar andrepereiradasilva
andrepereiradasilva - comment - 14 May 2016

seems fine to me now.

avatar zero-24
zero-24 - comment - 14 May 2016

Back to Pending. Thanks @wojsmol and @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2016
Labels Removed: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 May 2016

This PR has received new commits.

CC: @brianteeman, @BurtNL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar andrepereiradasilva andrepereiradasilva - test_item - 16 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 May 2016

I have tested this item :white_check_mark: successfully on fd6e877

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar brianteeman brianteeman - test_item - 23 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 May 2016

I have tested this item successfully on fd6e877


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar brianteeman brianteeman - change - 23 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 23 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406.

avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2016
Labels Added: ?
avatar roland-d roland-d - change - 24 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-24 10:15:09
Closed_By roland-d
avatar roland-d roland-d - close - 24 May 2016
avatar roland-d roland-d - merge - 24 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 24 May 2016
avatar roland-d roland-d - reference | 14d6b0f - 24 May 16
avatar roland-d roland-d - merge - 24 May 2016
avatar roland-d roland-d - close - 24 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 24 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment