Feeling Lucky
?
[#10405] - [mod_search] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
- Fixed in Code Base
- 16 May 2016
- Medium
- Build: staging
- # 10405
- Diff
- zero-24:patch-15
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10399 .
Summary of Changes
Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
Testing Instructions
- Enable the mod_search module to the frontend
- see that it works
- apply this patch
- see that it still works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
infograf768
- comment
- 12 May 2016
Any reason (in this PR as well as in other similar PRs) to not use ENT_QUOTES instead of ENT_COMPAT.
ENT_QUOTES would also take care of single quotes.
Bakual
- comment
- 12 May 2016
ENT_COMPAT is the default case for the method. So no functionality changes here this way. If it worked before, it will still work afterwards.
It's just the added encoding that is important here.
BurtNL
- comment
- 12 May 2016
I have tested this item 
successfully on 95c256d
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10405.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 12 May 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 15:59:34 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 95c256d
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10405.