? ? Failure

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
10 May 2016

Pull Request is a redo for #8513
With some additions:

  • Usage of JLayout
  • Script version 2.0
  • Removal of hardcoded staff
avatar dgt41 dgt41 - open - 10 May 2016
avatar dgt41 dgt41 - change - 10 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Added: ? ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 10 May 2016

Important for testers: Please test the installation process of Joomla! because we've encountered an issue during the Code Sprint in Manchester after we've merged the previous state of this PR (maybe it is already fixed?). Thanks!

avatar zero-24
zero-24 - comment - 10 May 2016

@dgt41 does the script also support min integers, min symbols and min uppercase too?

avatar zero-24 zero-24 - change - 10 May 2016
Category JavaScript
avatar zero-24 zero-24 - change - 10 May 2016
Easy No Yes
avatar zero-24
zero-24 - comment - 10 May 2016

How to test

First test
  • Install that patch
  • go to the user manger in backend
  • add a new user
  • see the Password strength indication for the password field.
  • try to enter the username as password
  • see the message
  • set the minimum lenth of the password to 20
  • try a password
  • see the message
seccond test
avatar dgt41
dgt41 - comment - 10 May 2016

@zero-24 these are the default rules

defaultOptions.rules.activated = {
     wordNotEmail: true,
     wordLength: true,
     wordSimilarToUsername: true,
     wordSequences: true,
     wordTwoCharacterClasses: false,
     wordRepetitions: false,
     wordLowercase: true,
     wordUppercase: true,
     wordOneNumber: true,
     wordThreeNumbers: true,
     wordOneSpecialChar: true,
     wordTwoSpecialChar: true,
     wordUpperLowerCombo: true,
     wordLetterNumberCombo: true,
     wordLetterNumberCharCombo: true
 };

So there are a lot of options/combinations but the rules are specific to 1,2 or 3 uppercase,number,special character so overriding these we can justify the rule for 1,2 or 3 e.g. special characters.
Thanks for the test instructions

66426be 10 May 2016 avatar dgt41 map
de6ccc0 10 May 2016 avatar dgt41 CS
avatar brianteeman
brianteeman - comment - 10 May 2016

What are character classes?

Use different character classes

avatar brianteeman
brianteeman - comment - 10 May 2016

Will not install. Installer not loading correctly no header etc in the html

avatar brianteeman brianteeman - test_item - 10 May 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 10 May 2016

I have tested this item :red_circle: unsuccessfully on 7f90087


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar brianteeman brianteeman - change - 10 May 2016
Category JavaScript Installation JavaScript Language & Strings
avatar brianteeman brianteeman - change - 10 May 2016
Labels
avatar 810
810 - comment - 10 May 2016

@zero-24 with you package it is failing:
warning
JLIB_APPLICATION_ERROR_COMPONENT_NOT_LOADING

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar zero-24
zero-24 - comment - 10 May 2016

@801 what do you meam? It is just the repo of this PR?!

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar brianteeman brianteeman - test_item - 10 May 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 10 May 2016

I have tested this item :red_circle: unsuccessfully on 4fad4f2

Go to installation - complete step 1 and click next to go to step 2
Decide you want to change the password so click on the first tab to return to step 1
Password script is no longer in use on this page


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar brianteeman
brianteeman - comment - 10 May 2016

Also if your confirm password is not match the password the javascript is no longer loaded


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar 810
810 - comment - 10 May 2016

@zero-24 srry I thought you forked his pr.

@test I can still use admin - admin

avatar brianteeman
brianteeman - comment - 10 May 2016

If when registering a user you get a message such as

Your password cannot contain your username

Then I would expect not to be able to save the user with that password
Currently you can which kind of defeats the object of this to me


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar brianteeman
brianteeman - comment - 10 May 2016

This is not ready for testing at all. Not even sure if it usable in its
current form

On 10 May 2016 at 13:54, Jelle Kok notifications@github.com wrote:

@zero-24 https://github.com/zero-24 srry I thought you forked his pr.

@test https://github.com/test I can still use admin - admin


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10377 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 10 May 2016

@brianteeman was the previous behaviour like the one you are describing above or was it just an indication? If not I guess you are right and we should match the old behaviour

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar brianteeman brianteeman - test_item - 10 May 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 10 May 2016

I have tested this item :red_circle: unsuccessfully on dfdee29

Problems I reported above about the installation are still not fixed

Sorry I wont be wasting my time testing this again.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar roland-d roland-d - change - 24 Jun 2016
Status Pending Information Required
Labels
avatar roland-d
roland-d - comment - 24 Jun 2016

Hello @dgt41

Thank you for your contribution.

The last comment here was on May 10th. Can you update this PR please?
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10377.

avatar dgt41
dgt41 - comment - 24 Jun 2016

I will redo this with own script to match the exact old behaviour. Thanks

avatar dgt41 dgt41 - change - 24 Jun 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-06-24 23:07:21
Closed_By dgt41

Add a Comment

Login with GitHub to post a comment