[#10364] - Remove testing data from distribution
- Fixed in Code Base
- 23 Jul 2016
- Medium
- Build: staging
- Easy Test
- # 10364
- Diff
- zero-24:removetestingfromstable
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10330
Summary of Changes
- remove the testing files from the core stable versions
Testing Instructions
- run the build
- see that the testing files are not there
- run the installation
- see that there is no testing sample files option.
Thanks @brianteeman
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
writing test instructions was the longest part 
| Category | ⇒ | CLI Installation |
shouldn't it be removed in com_admin too?
... no? The entire installation directory is removed when you install a site so it doesn't persist across versions unless you core hacked the install check.
"entire installation directory" should be "removed when you install a site"
But yes, makes sense
Is this something the PLT need to decide on?
... or just no interest any more?
I am definitely in favour of this
On 2 June 2016 at 12:06, zero-24 notifications@github.com wrote:
... or just no interest any more?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10364 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8cLFZeAcbfnw2bNFFWE58IbOVtgNks5qHrkygaJpZM4Iaazy
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10364.
Thanks :)
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10364.
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10364.
I was trying to test it and tried to follow testing instructions. but didn't able to understand how exactly I can test this Pull request. Somehow I reached to build folder and found build.php and it needs to run from cli. But that doesn't work for me when I have downloaded https://codeload.github.com/zero-24/joomla-cms/zip/removetestingfromstable and tried to run php build.php from build folder.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10364.
@pritalpatel can you explain what don't work? I have just add 3 files to be excluded from the core installation the script should run normaly. Can you confirm that the issues come from the changes here? Are you able to user the build.php from core?
This PR has received new commits.
CC: @brianteeman
@brianteeman i have just synced to staging. Nothing new to test ;)
| Category | CLI Installation | ⇒ | Repository |
I have tested this item
run build
Newbie comment:
Puuh. After some hours it ran finally ;-)
testing datas not present in full packages anymore
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10364.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10364.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-23 08:35:27 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Not even a 10 minute PR :)