Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10363] - Review and cs for the other files in the install folder

? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
9 May 2016

Summary of Changes

Code Review and Cs for the models folder of the installation

Testing Instructions

Confirm that the installation still works with this branch: https://github.com/zero-24/joomla-cms/archive/installcsother.zip

87fa3dc 9 May 2016 avatar zero-24 typo
avatar zero-24 zero-24 - open - 9 May 2016
avatar zero-24 zero-24 - change - 9 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 9 May 2016

@mbabker can you help me? Travis told me something i don't understand: https://travis-ci.org/joomla/joomla-cms/jobs/128932764

FILE: /home/travis/build/joomla/joomla-cms/installation/template/index.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 52 | ERROR | Closing brace must be on a line by itself
 54 | ERROR | Closing brace must be on a line by itself
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

I can't see any wrong brace there?!

avatar mbabker
mbabker - comment - 9 May 2016

The PHPCS ruleset needs edited, the template's index.php file should be on the ignore list for whatever rule the other layouts have that allow that to work. Or just revert it and leave it alone.

avatar zero-24
zero-24 - comment - 9 May 2016

Thanks i have just add it to the general roule to ignore that file @mbabker

avatar brianteeman brianteeman - change - 9 May 2016
Category ⇒ Code style
avatar zero-24
zero-24 - comment - 13 May 2016

Thanks @brianteeman i have just fixed / removed the extra line ;)

avatar zero-24 zero-24 - change - 24 Jun 2016
Easy No ⇒ Yes
avatar pritalpatel pritalpatel - test_item - 13 Jul 2016 - Tested successfully
avatar pritalpatel
pritalpatel - comment - 13 Jul 2016

I have tested this item ✅ successfully on a5ddef1

Installed using provided link. It works normally.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10363.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2016
Category Code style ⇒ Repository Installation Code style
avatar zero-24
zero-24 - comment - 21 Jul 2016

Is this so hard to test? Please let me know what is unclear than I can add a better desciption ;)

avatar bertmert bertmert - test_item - 22 Jul 2016 - Tested successfully
avatar zero-24 zero-24 - change - 22 Jul 2016
Status Pending ⇒ Ready to Commit
avatar bertmert
bertmert - comment - 22 Jul 2016

I have tested this item ✅ successfully on d5975af

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10363.

avatar zero-24
zero-24 - comment - 22 Jul 2016

Thanks. RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10363.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2016
Labels Added: ?
avatar roland-d roland-d - close - 23 Jul 2016
avatar roland-d roland-d - merge - 23 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 23 Jul 2016
avatar roland-d roland-d - change - 23 Jul 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-07-23 08:29:03
Closed_By ⇒ roland-d
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment