? Failure

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
8 May 2016

Pull Request for Issue #10293.

Summary of Changes

Solves #10293

Testing Instructions

Code review, or:

  1. Logout
  2. Login and go to Menus -> Manage
  3. Now click in the sidebar "Menu items"
  4. No 403 now.
avatar andrepereiradasilva andrepereiradasilva - change - 8 May 2016
Status New Pending
avatar andrepereiradasilva andrepereiradasilva - open - 8 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 8 May 2016
Title
solves https://github.com/joomla/joomla-cms/issues/10293
solves #10293
avatar andrepereiradasilva andrepereiradasilva - change - 8 May 2016
The description was changed
Title
solves https://github.com/joomla/joomla-cms/issues/10293
solves #10293
avatar pe7er pe7er - test_item - 8 May 2016 - Tested successfully
avatar pe7er
pe7er - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on f7429ad

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10314.

avatar grhcj grhcj - test_item - 8 May 2016 - Tested successfully
avatar grhcj
grhcj - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on f7429ad


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10314.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

@pe7er @grhcj thanks for testing!

avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 8 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10314.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar wilsonge wilsonge - reference | 662e0ce - 8 May 16
avatar wilsonge wilsonge - merge - 8 May 2016
avatar wilsonge wilsonge - close - 8 May 2016
avatar wilsonge wilsonge - change - 8 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-08 14:41:20
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 May 2016
avatar wilsonge wilsonge - merge - 8 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 8 May 2016
avatar wilsonge wilsonge - change - 8 May 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 8 May 2016
avatar bembelimen
bembelimen - comment - 8 May 2016

Wouldn't it be better to get the first valid menu instead of all menu items? Reason: in J! 3.5 you get the "mainmenu" if you click on this link (als default), so we could implement a similar behavior

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

well i don't know which is better, ask @infograf768

i just made this PR to solve the 403 error.

Add a Comment

Login with GitHub to post a comment