? Pending

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
8 May 2016

Pull Request for Issue #9564

Summary of Changes

Fixed merge conflicts.

Testing Instructions

Is already tested (origin PR is RTC), can be merged directly.

All kudos to @nishadi!

avatar Kubik-Rubik Kubik-Rubik - open - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Milestone Added:
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

please don't revert the changes i made here
https://github.com/joomla/joomla-cms/pull/10062/files

avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

@andrepereiradasilva Thanks for the hint, I will update the PR.

avatar andrepereiradasilva andrepereiradasilva - test_item - 8 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on bb266a9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10313.

avatar brianteeman brianteeman - change - 8 May 2016
Category Components
avatar brianteeman brianteeman - test_item - 8 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on bb266a9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10313.

avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 8 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10313.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 9 May 2016

@Kubik-Rubik please fix the CS issues

avatar andrepereiradasilva
andrepereiradasilva - comment - 9 May 2016

@rdeutz there are no cs issues where, yesterday travis has crazy. this is ok.

avatar rdeutz
rdeutz - comment - 9 May 2016

@andrepereiradasilva, ok, I have restarted travis, we will see :-)

avatar mbabker
mbabker - comment - 9 May 2016

Restarting Travis won't fix it because it's based on the branch this PR came from, not a merge of this branch onto staging. @Kubik-Rubik would need to merge in staging to get a clean build.

avatar andrepereiradasilva
andrepereiradasilva - comment - 9 May 2016

travis ok :)

avatar rdeutz
rdeutz - comment - 9 May 2016

@mbabker seems it worked, or do you expect that Jenkins will show the middle finger

avatar mbabker
mbabker - comment - 9 May 2016

Bleh, whatever. Hit the damn button. If it breaks, blame George.

avatar andrepereiradasilva
andrepereiradasilva - comment - 9 May 2016

LOL!

avatar rdeutz rdeutz - change - 9 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-09 20:54:05
Closed_By rdeutz
avatar rdeutz rdeutz - close - 9 May 2016
avatar rdeutz rdeutz - merge - 9 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 9 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment