[#10290] - [com_finder] Add submenu
- Closed
- 5 Sep 2016
- Medium
- Build: staging
- # 10290
- Diff
- andrepereiradasilva:com_finder_submenu
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR adds the missing submenu for com_finder.
Smart Search is the only component with sidebar that doesn't have the submenu.
Testing Instructions
Two tests needed:
Install
- Install clean joomla using https://github.com/andrepereiradasilva/joomla-cms/archive/com_finder_submenu.zip package
- Check the Components -> Smart Search has a new submenu.
Update
- Go to Components -> Joomla update -> Uplaod and install
- Install my custom package (download from https://github.com/andrepereiradasilva/update.joomla.org/raw/master/submenu-on-update.zip)
- Check the Components -> Smart Search has a new submenu.
Observations
- I don't understand very well the
lftandrgtdatabase fields. Can anyone check those in the sql insert commands? - Only tested in Mysql. If anyone can test on postgresql would be great.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
No, the update SQL is needed. On install and update Joomla will update the manifest_cache column of the extensions table for core extensions with the updated data for the XML manifests. It doesn't actually run individual extension updates.
i need to understand the lft/rgt values and have a way to rebuild then on update ...
I will put this in standby for now.
| Category | ⇒ | Components |
| Labels | |||
I can help you on this. I will try to submit a pull request to your repo but if I forget please remind me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10290.
ok thanks!
| Labels | |||
@andrepereiradasilva & @brianteeman little reminder
This is a good UX improvement, so I would like to test it went completely finished.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10290.
waitng for brian to have time on this one
Sorry @andrepereiradasilva what is it I am supposed to be helping with - I am forgetful
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10290.
andrepereiradasilva said
i need to understand the lft/rgt values and have a way to rebuild then on update ...
I will put this in standby for now.
brian said
I can help you on this. I will try to submit a pull request to your repo but if I forget please remind me
Ok I will try to remember how
@andrepereiradasilva
Michael is right it doesnt really matter for updated and seems to be a bit of a mess anyway
Obviously you need to rename your update files now with the new version ;)
Best thing I can suggest to get the correct lft/rgt values is to runs the sql you have right now. then go to the menu manager. make sure all menu items is selected and click on rebuild
that should give you the correct values
closing as no intenttion to pursue this anymore
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-05 22:07:53 |
| Closed_By | ⇒ | andrepereiradasilva |
@mbabker, so, is this PR i don't need to add the SQL to update, since joomla will read the manisfest on update and create the submenus right?