Feeling Lucky
?
[#10289] - [bump.php] Regex pattern match
- Closed
- 7 May 2016
- Medium
- Build: staging
- # 10289
- Diff
- andrepereiradasilva:patch-4
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
The new replace of bump.php uses a not so correct pattern match [^<]*. It should be [^ ]*, since where we want to end the pattern match (for replace) is a space character and not the less sign (<).
Testing Instructions
In joomla root dir, run CLI command php build/bump.php -v 3.7.0
And then check the /build.xml for Joomla! CMS 3.7 API
Then use php build/bump.php -v 3.6.0-dev to go back to previous state.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
andrepereiradasilva
- comment
- 7 May 2016
ehhe
the regex is currently working because you have no less (<) character in that line.
But is not correct. This PR corrects it.
BTW. The travis error is nothing to do with this PR.
Can be merged on review IMHO.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 17:42:02 |
| Closed_By | ⇒ | wilsonge |
brianteeman
- | Category | ⇒ | CLI |
| Milestone |
Added: |
||
Regex ain't my thing so if it works it works.