[#10257] - [com_finder] maps view: Indexed content counting and other improvements
- Fixed in Code Base
- 8 May 2016
- Medium
- Build: staging
- # 10257
- Diff
- andrepereiradasilva:com_finder_maps-improvements
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR adds some improvements to Smart Search Content Maps:
- Add a label to each content map title (it was missing)
- Adds link to view only the first level sublevels in the blue badges.
- Adds counting and corresponding links to "Indexed Content" view.
Before PR
After PR
Testing Instructions
3 simple test needed.
Apply patch
Go to Smart Search -> Indexed Content and run the index
Go to Smart Search -> Content Maps
-
Click on a content map "Title" and check that in that row the select box is checked.
ok = test 1 passed
-
Click on the blue level 1 badge. and confirm it showns only the sublevels after click. Clear the filter after.
ok = test 2 passed
-
Confirm the published/unpublished counting is working properly and they link to the index content view with the corresponding filter.
Please note that the content_map will only be activated if PR #10256 is also installed, but you can check the resulting URL (check the filter is there) for this test propose.ok = test 3 passed
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Labels | |||
| Category | ⇒ | Language & Strings Search |
| Labels | |||
ok will check that.
This PR has received new commits.
CC: @grhcj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
This PR has received new commits.
CC: @grhcj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
This PR has received new commits.
CC: @grhcj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
This PR has received new commits.
CC: @grhcj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
ok should be fixed now.
This PR has received new commits.
CC: @grhcj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
I have tested this item 
successfully on ed45c32
In test 3, the filter param was present in the URL, but I can't verify that the filter value is right.
Because this shouldn't be part of this PR, I didn't do further tests on this.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
I have tested this item successfully on ed45c32
Works as described now that #10256 has been merged. Nice improvement.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC -before merging please double check the unrelated Travis issue
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 15:05:33 |
| Closed_By | ⇒ | wilsonge |
Travis is unrelated and now fixed in staging. Merging this
| Labels |
Removed:
?
|
||
thanks for testing, comments and merging!
I have tested this item
unsuccessfully on e19edeb
With this PR applied, I get
Notice: Undefined property: stdClass::$num_nodes in [...]\administrator\components\com_finder\views\maps\tmpl\default.php on line 134for every element at content maps view.
I cleared my browser cache and tested with latest staging.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257.