? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
5 May 2016

Pull Request for Improvement.

Summary of Changes

This PR adds a new filter to the com_finder (smart search) index view.

image

Testing Instructions

  1. Apply patch
  2. Go to Smart Search -> Indexed Content and test the new filter.
avatar andrepereiradasilva andrepereiradasilva - open - 5 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 5 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 5 May 2016
The description was changed
avatar brianteeman brianteeman - change - 5 May 2016
The description was changed
Labels
avatar brianteeman brianteeman - change - 5 May 2016
Labels
avatar brianteeman brianteeman - change - 5 May 2016
Category Language & Strings Search
avatar andrepereiradasilva andrepereiradasilva - change - 5 May 2016
Title
[com_finder] Add content map filter
[com_finder] index view: Add content map filter
a10733e 5 May 2016 avatar andrepereiradasilva cs
avatar chrisdavenport
chrisdavenport - comment - 5 May 2016

How does the drop-down perform when you have hundreds of options in it?

avatar brianteeman
brianteeman - comment - 5 May 2016

Probably quite badly based on the previous performance issues with a chosen select

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 May 2016

@chrisdavenport to be honest just tested with joomla sample data index (46 items in content maps) with no notice change in page speed rendering.

Will try to test tomorrow with more items.

avatar andrepereiradasilva
andrepereiradasilva - comment - 6 May 2016

just tested with a random generated 5000 items content map! 200ms difference. Also a bit of 100ms opening the filter. The search is instant. I'm simulating a huge 5000 content map tree...

I don't have a huge search index database to test more properly. @chrisdavenport do you have it?

avatar andrepereiradasilva
andrepereiradasilva - comment - 6 May 2016

we could also do as the frontend and add the same filters the frontend have, instead of a all in one content map filter. (types are already there, so author, category and language). But i'm not sure about this, because for what i understand the level 1 branches are dynamic.

avatar brianteeman brianteeman - test_item - 7 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on a10733e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256.

avatar zero-24 zero-24 - test_item - 8 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on a10733e

looks good to me. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256.

avatar zero-24 zero-24 - change - 8 May 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 8 May 2016

Works and look good now -> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 8 May 2016
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

Thank you @andrepereiradasilva and testers!

avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-08 14:04:22
Closed_By Kubik-Rubik
avatar zero-24
zero-24 - comment - 11 May 2016

please remove the label @joomla-cms-bot

avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment