Just one comment, you need to add the a.header ordering (ASC and DESC) to the filter xml to (https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_redirect/models/forms/filter_links.xml#L43).

This way it will appear in the ordering select box (and be selected when you order by that colunm).

@andrepereiradasilva
Thanks for your comment, I just added the two lines to filter_links.xml (the necessary messages were already defined in en-GB.com_redirect.ini).

The only problem I see with this change is that the redirect status code is shown only if advanced mode is on. but as far as I understand this filter_links.xml definition the two ordering variants will be shown always - even when advanced mode is off. Is there any way to show them conditionally?

That i know of, as it is now, there is only one case that happens, the language associations (only exists when site is multilinguage).

See https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/forms/filter_articles.xml#L101-L102

I have tested this item successfully on 9df9c9d

When you are not in advanced mode the Status Code column disappears but the Sort by Status Ascending in the dropdown select is still present

@brianteeman that's what @jo-sf and i discussed in the comments above.

There is not, that i know of, a way to do this in the XML (see comments above).

You have two options:
1. Don't add to the xml. Problem: when in advanced mode you will have a problem in the filter when ordering by that columns
2. Add to xml. Problem: it appear in the ordering list when you don't have advanced mode and the column don't exist.

So, IMHO the second option is better.

BTW what is advance mode for? Can't all the options exist without the advance mode option? There is no other component in joomla that does this.

OK - I have no problem with it being in the dropdown list if that cannot be
avoided.

Advanced mode was one of those compromises. Someone wanted to add the
functionality. Someone else felt it would confuse regular users

On 4 May 2016 at 10:34, andrepereiradasilva notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman that's what @jo-sf
https://github.com/jo-sf and i discussed in the comments above.

There is not, that i know of, a way to do this in the XML (see comments
above).

You have two options:
1. Don't add to the xml. Problem: when in advanced mode you will have a
problem in the filter when ordering by that columns
2. Add to xml. Problem: it appear in the ordering list when you don't have
advanced mode and the column don't exist.

BTW what is advance mode for? Can't all the options exist without the
advance mode option? There is no other component in joomla that does this.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10217 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

IMO this "Advanced mode" confudes even further. but ok...

I have tested this item successfully on 9df9c9d

I have tested this item successfully on 9df9c9d

I am setting this to Needs Review so that the CMS maintainers can make a decision about the dropdown select issue - hopefully that wil me made at the sprint this weekend

I think the advanced mode allowing to set any HTTP status code beside 301 (the default) is OK, since setting an inappropriate code here might lead to problems later (see the hint shown when passing over the field label).

But we could show the status code column always even if the advanced mode is off. In this case the default status code (301) is shown and there is no problem with showing the "sort by" alternatives for this column. Moreover it would remove some complexity from the code...

i agree

@brianteeman
What do you think about always showing the status code column?

If you agree too I'll change my PR accordingly.

I see no reason why not myself so go for it and lets see what others think

On 4 May 2016 at 20:39, jo-sf notifications@github.com wrote:

@brianteeman https://github.com/brianteeman
What do you think about always showing the status code column?

If you agree too I'll change my PR accordingly.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10217
https://issues.joomla.org/tracker/joomla-cms/10217.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10217 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

Now the "Status Code" column will be shown always regardless of the setting of the advanced mode. So the two items in the sorting dropdown menu are always valid.

I have tested this item successfully on 60a3b7e

@andrepereiradasilva
Wow you're really fast!

with the patchtester is easy

I have tested this item successfully on 60a3b7e

RTC