What is the benefit of swapping the user and subject columns? for me at
least the primary field to search by is the user that the note refers to

On 3 May 2016 at 15:24, andrepereiradasilva notifications@github.com
wrote:

Summary of Changes

Add features:

• Drop down actions (to be consistent with other views)

Solves bugs:

• ACL has not working reggarding the user note category
• Checkin has not working at all

Other adjustments:

• Exchange user and subject columns
• Moves the edit link from the user to the note subject
• Moves category to below the note subject to align with other views.
• Improves mobile rendering
• Corrects table footer colspan
• Small code improvements

Before PR

[image: image]
https://cloud.githubusercontent.com/assets/9630530/14986248/efe2f2f4-1142-11e6-850e-ba2ff71410ee.png
After PR

[image: image]
https://cloud.githubusercontent.com/assets/9630530/14986051/28e039f0-1142-11e6-81cb-0bba7bceb6d6.png
Testing Instructions

Do a general testing of the user notes list view.

You can view, comment on, or merge this pull request online at:

#10215
Commit Summary

• user notes improvements
• reorder ordering to match table

File Changes

• M administrator/components/com_users/models/forms/filter_notes.xml https://github.com/joomla/joomla-cms/pull/10215/files#diff-0 (4)
• M administrator/components/com_users/views/notes/tmpl/default.php https://github.com/joomla/joomla-cms/pull/10215/files#diff-1 (71)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/10215.patch
• https://github.com/joomla/joomla-cms/pull/10215.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10215

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

1. Is the note that belong to a category, not the user.
2. IMO the goal of this view is to list the notes assigned to the users so we edit the note (not the user), identified by the note subject.

The primary purpose of the list views, in all joomla views is the first column after status. So in this should be to.

I have tested this item successfully, but have a question.
When you delete an user who has one or more notes attached to its account, the user record is deleted but the notes are kept without a relation to any user. So they become orphaned notes.
Are those notes kept on purpose? Or should they be deleted as well when the user is deleted?

@BurtNL there is no need to keep the notes record as it is useless once the user has been deleted. But I would say that should be addressed in a separate PR

@BurtNL please mark the test as successuffly in joomla issue tracker.

When you delete an user who has one or more notes attached to its account, the user record is deleted but the notes are kept without a relation to any user. So they become orphaned notes.
Are those notes kept on purpose? Or should they be deleted as well when the user is deleted?

I think it's a bug and they should be deleted, but that's out of the scope of this PR.

I have tested this item successfully on cf591be

Tested successfully, everything workes as described.
I agree with @andrepereiradasilva regarding the modifications to the interface. It has become much cleaner and more logical.
@andrepereiradasilva and @brianteeman : I hope @andrepereiradasilva will submit another PR for cleaning out leftover notes. I will be happy to test that as well.

I hope @andrepereiradasilva will submit another PR for cleaning out leftover notes.

or any other volunteer...

I have tested this item successfully on cf591be

RTC