Feeling Lucky
?
[#10139] - Usage of proper class inheritance check for limiting query
- Closed
- 9 Sep 2017
- Medium
- Build: staging
- # 10139
- Diff
- readybytes:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Pull Request for
# 10108
User tests: Successful: Unsuccessful:
Pull Request for Issue #10108
(Its a PR against the request at #10138)
Summary of Changes
While adding support for limitable interface.The checking of query objects type should be consistent.
Testing Instructions
extend a sample class MyQuery from JDatabaseQuery.
Use a simple select statement on $query = new MyQuery(); $query->select('user_id'); $query->where("1"); $query->limit(5,10); $results = JFactory::getDbo()->setQuery($query)->loadAssoclist();
Should get limited records.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
| Rel_Number | 0 | ⇒ | 10108 |
| Relation Type | ⇒ | Pull Request for |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-09 13:35:08 |
| Closed_By | ⇒ | brianteeman |
All drivers need to be checked for this. Just at a quick glance the abstract PDO driver and legacy MySQL driver has the same type of check.