While using limit & offset on a query objects (which is inherited from JDatabaseQuery but does not implement JDatabaseQueryLimitable), there is no way limit & offset can be utilized.
Query as -
$db->setQuery($query, $start,$offset)
It will set limit & offset on db object.
https://github.com/joomla/joomla-cms/blob/3.5.1/libraries/joomla/database/driver.php#L2115
But when the limit & offset is expected to be utilized a cross check is done on JDatabaseQuery
https://github.com/joomla/joomla-cms/blob/3.5.1/libraries/joomla/database/driver/mysqli.php#L569
This way in any way, I cannot apply limit & offset without implementing JDatabaseQueryLimitable.
Should return only limited records
Currently when we mention limit & offset on query, and execute it, it returns all records.
This is a simple fix, to check for same class.
Labels |
Added:
?
|
Closed as we have a pull request
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-30 09:49:53 |
Closed_By | ⇒ | brianteeman |
As it is a "simple fix" please submit a pull request